declaring variables in angularjs controller

Question

I am attempting to define a variable conn in my controller.js.

With the code at the bottom, I get lots of horrible UI glitches, so I'm presuming the code below is wrong. If I try:

var conn;
conn.name = 'Fred';

I get what looks like a NullPointer Error "Cannot set property 'name' of undefined" when I attempt to set conn.name.

How do I define my variable?

var addDBConnControllerBase = app.controller('addDBConnControllerBase',
function($scope,$http,serviceFactory,$modal,$location,$log)
{
    $scope.saveDBConn = function()
    {
        var conn = {
            name,
            driverType,
            connectionString,
            userID,
            password
        };
        conn.name = $scope.addDBConnController.displayName;
        conn.driverType = $scope.addDBConnController.driverType;
        conn.connectionString = $scope.addDBConnController.connectionString;
        conn.userID = $scope.addDBConnController.userID;
        conn.password = $scope.addDBConnController.password;
        $log.debug('Saving db conn');
        $log.debug(JSON.stringify(conn));
    }
});

I would use a service for saving connection settings. It's more "angular-way" — kravasb
– kravasb, Commented Apr 9, 2015 at 10:42
Using a service is the second part of my task. This is angular day 1 for me and I was just making sure I could get the data from the screen to the controller to start with. :-) — James Hutchinson
– James Hutchinson, Commented Apr 9, 2015 at 10:56

Rishi Prakash · Accepted Answer · 2015-04-09 10:32:50Z

4

var newAttrs = {};
newAttrs[nameOfProp] = valueOfProp;

try this!!!

In your case I think this would be

var conn = {};
conn["name"] = 'Fred';

answered Apr 9, 2015 at 10:32

Rishi Prakash

1,8092 gold badges18 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2847643 · Accepted Answer · 2015-04-09 10:47:07Z

4

You need to brush up on your javascript pronto! This:

var conn;

is a variable declaration, not definition. conn is still undefined after this statement so you can't go conn.name = .... You have to initialize things before you use them:

var conn = {};
conn.name = ...

or

var conn = {
  name: ...
};

answered Apr 9, 2015 at 10:47

user2847643

2,93517 silver badges23 bronze badges

Comments

kishan · Accepted Answer · 2015-04-09 10:33:15Z

-1

You should define variable conn as an array first. Like following.

var conn = [];
conn.name=$scope.addDBConnController.displayName;

answered Apr 9, 2015 at 10:33

kishan

3013 silver badges12 bronze badges

3 Comments

user2847643 Over a year ago

Eeeeerrr, [] is not how you initialize objects.

James Hutchinson Over a year ago

I don't need an array. But thanks anyway. I learned something new :-)

Rishi Prakash Over a year ago

[] is an array, {} is an object.

Collectives™ on Stack Overflow

declaring variables in angularjs controller

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related