python-flask db.session.commit() is not working

Question

The problem is when user tries 'forgot password' option. It creates new reset_key for verification, but the new key is not getting updated into DB.

@app.route('/login/forgot/', methods=['GET', 'POST'])
def forgot():
   form = ResetLoginForm(request.form)
   #There's no session yet. User just pointing to /login/forgot url.

   if request.method == 'POST' and form.validate():
      user = User.query.filter_by(email=form.email.data).first()

   if not user:
     flash('The username or email incorrect')
     return render_template('forgot.html', form=form)

   reset_key = generate_key() ## this creates a new key, but how update  this key into db?
   #tried something like 
   user.reset_key = reset_key 
   db.session.add(user)
   db.session.commit()
   #this is not working. Is it due to session is not started or something?

Thanks for any help or hint.

Remove the line that adds a new user record: db.session.add(user) — dylrei
– dylrei, Commented Mar 22, 2015 at 17:54

ballade4op52 · Accepted Answer · 2018-01-15 00:35:21Z

12

This is because User.query.filter_by(email=form.email.data).first() will return a sqlalchemy.orm.query.Query object. As its doc says:

Query is the source of all SELECT statements generated by the ORM, both those formulated by end-user query operations as well as by high level internal operations such as related collection loading. It features a generative interface whereby successive calls return a new Query object, a copy of the former with additional criteria and options associated with it.

So you just get a copied object, so your change will not work;

You can use like this: user = db.session.query(User).filter_by(email==form.email.data).first() and then you can change user attrs

edited Jan 15, 2018 at 0:35

ballade4op52

2,2675 gold badges29 silver badges44 bronze badges

answered Dec 30, 2015 at 4:48

gkiwi

6108 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jcfollower Over a year ago

I think filter_by has one more equals symbol than it should, right, i.e. ...(email=form.email.data)...?

Evgene · Accepted Answer · 2020-05-30 16:18:23Z

0

user = db.session.query(User).first() solved problem.

answered May 30, 2020 at 16:18

Evgene

6268 silver badges15 bronze badges

Collectives™ on Stack Overflow

python-flask db.session.commit() is not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related