Parsing JSON to custom ArrayList, only returning last item?

Question

I'm finding this a bit odd, I'm parsing some JSON from a file in my /assets folder. I have set up a custom ArrayList. Now when I try and add data from the ArrayList to a listview, or a spinner (Same adapter) it only shows the last item. Here is my code:

My parsing method:

public ArrayList<ShopName> parseJSON(String json) {

    ArrayList<ShopName> shop = new ArrayList<>();
    ShopName item = new ShopName();

    Log.d(TAG, json);
    try {

        JSONArray jArray = new JSONArray(json);

        for (int i=0; i < jArray.length();i++) {
            JSONObject jObject = jArray.getJSONObject(i);
            item.setFromCurrency(jObject.getString("from"));
            item.setToCurrency(jObject.getString("to"));
            item.setRate(jObject.getString("cost"));
            data.add(item);
        }
    } catch (JSONException jen) {
        jen.printStackTrace();
    }
    return shop;
}

I'm not quite sure where my error is. Am I parsing it incorrectly, maybe, storing it incorrectly? I have a feeling it's my ArrayList but I'm sure what I should be doing to fix it, I've tried using different Adapters, and searching StackOverflow but they all have difference issues so it's hard to narrow now.

I would appreciate your help on this. Thank you.

@John done, although it's nothing special, just the width and height defined, it's sitting within a relativelayout. — gDot
– gDot, Commented Mar 22, 2015 at 1:44

Andyccs · Accepted Answer · 2015-03-22 01:47:08Z

2

public ArrayList<Data> parseJSON(String json) {

    ArrayList<Data> data = new ArrayList<>();
    // Data item = new Data();  // Move this into for loop

    Log.d(TAG, json);
    try {

        JSONArray jArray = new JSONArray(json);

        for (int i=0; i < jArray.length();i++) {
            Data item = new Data();
            JSONObject jObject = jArray.getJSONObject(i);
            item.setFromCurrency(jObject.getString("from"));
            item.setToCurrency(jObject.getString("to:"));
            item.setRate(jObject.getString("rate"));
            data.add(item);
        }
    } catch (JSONException je) {
        Log.d(TAG, je.getMessage());
    }
    return data;
}

answered Mar 22, 2015 at 1:47

Andyccs

5353 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

gDot Over a year ago

Thank you. This fixed it. I realise now that I have create a new instance of data each time otherwise it will overwrite the previous data.

Konstantin Burov · Accepted Answer · 2015-03-22 01:47:25Z

2

You only initialize item object once, that's why. Move

Data item = new Data();

Into your for loop.

answered Mar 22, 2015 at 1:47

Konstantin Burov

69.3k16 gold badges117 silver badges93 bronze badges

Comments

owenrb · Accepted Answer · 2015-03-22 01:51:45Z

0

You should create new Data object for each JSON array item.

public ArrayList<Data> parseJSON(String json) {

    // remove this    
    // Data item = new Data();  

   ...
    try {

        JSONArray jArray = new JSONArray(json);

        for (int i=0; i < jArray.length();i++) {
            // move it here
            Data item = new Data(); 
            ...
            data.add(item);
        }
    } catch (JSONException je) {
        Log.d(TAG, je.getMessage());
    }
    return data;
}

answered Mar 22, 2015 at 1:51

owenrb

5352 silver badges7 bronze badges

Collectives™ on Stack Overflow

Parsing JSON to custom ArrayList, only returning last item?

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related