How can I create an image file from bitmapsource C# WPF

Question

I have tried as follows

BitmapSource bitmap;
            bitmap = graphData.CreateScreenshot();
            JpegBitmapEncoder encoder = new JpegBitmapEncoder();
            BitmapFrame outputFrame = BitmapFrame.Create(bitmap);
            encoder.Frames.Add(outputFrame);
            encoder.QualityLevel = 100;
            FileStream stream = new FileStream("test.jpg", FileMode.Create);
            encoder.Save(stream);

but I am not able to view the image. I can see following message:

Windows photo viewer can't open this picture because the picture is being edited in another program

What went wrong here?

tried stream.close() ?

Muds
– Muds

2015-03-18 10:17:22 +00:00
Commented Mar 18, 2015 at 10:17 — Muds
– Muds, Commented Mar 18, 2015 at 10:17

Clemens · Accepted Answer · 2015-03-18 11:04:22Z

2

You should try and Close the stream after you've created it using

stream.Close();

That said, it would be better to create the Stream in a using statement. The Stream would be disposed of when execution leaves the using block and would hence be closed automatically.

using (var stream = new FileStream("test.jpg", FileMode.Create))
{
    encoder.Save(stream);
}

edited Mar 18, 2015 at 11:04

Clemens

129k13 gold badges163 silver badges296 bronze badges

answered Mar 18, 2015 at 10:18

Jordan Coulam

3591 silver badge13 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Jordan Coulam Over a year ago

Looks like people beat me too it in the comments

Jordan Coulam Over a year ago

Have a look at the Using statement msdn.microsoft.com/en-us/library/yh598w02.aspx also if it's working now mark as answered. Glad to help.

Muds Over a year ago

its ok I will let you take this one :)

Jordan Coulam Over a year ago

Muds, Sorry I genuinely was writing this as you commented I had to build a project to double check. :<

masterw Over a year ago

Small advice: put it in a using pattern to make it more readable and to prevent issues like this.

Collectives™ on Stack Overflow

How can I create an image file from bitmapsource C# WPF

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related