Use an Array to Cycle Through a MySQL Where Statement

Question

I'm trying to create a loop that will output multiple where statements for a MySQL query. Ultimately, my goal is to end up with these four separate Where statements:

`fruit` = '1' AND `vegetables` = '1'
`fruit` = '1' AND `vegetables` = '2'
`fruit` = '2' AND `vegetables` = '1'
`fruit` = '2' AND `vegetables` = '2'

My theoretical code is pasted below:

<?php

$columnnames = array('fruit','vegetables');
$column1 = array('1','2');
$column2 = array('1','2');

$where = '';
$column1inc =0;
$column2inc =0;

while( $column1inc <= count($column1) ) {
    if( !empty( $where ) )
    $where .= ' AND ';
    $where = "`".$columnnames[0]."` = ";
    $where .= "'".$column1[$column1inc]."'";

    while( $column2inc <= count($column2) ) {
        if( !empty( $where ) )
        $where .= ' AND ';
        $where .= "`".$columnnames[1]."` = ";
        $where .= "'".$column2[$column2inc]."'";

            echo $where."\n";

    $column2inc++;
}

$column1inc++;
}

?>

When I run this code, I get the following output:

`fruit` = '1' AND `vegetables` = '1'
`fruit` = '1' AND `vegetables` = '1' AND `vegetables` = '2'
`fruit` = '1' AND `vegetables` = '1' AND `vegetables` = '2' AND `vegetables` = ''

Does anyone see what I am doing incorrectly? Thanks.

halfdan · Accepted Answer · 2010-05-23 16:39:05Z

1

I'm suggesting the following code:

$columnnames = array('fruit','vegetables');
$column1 = array('1','2');
$column2 = array('1','2');

$list = array();
for($i = 0; $i < count($column1); $i++) {
        for($k = 0; $k < count($column2); $k++) {
                $str = sprintf("`%s` = `%d` AND `%s` = `%d`",
                        $columnnames[0], 
                        $column1[$i], 
                        $columnnames[1], 
                        $column2[$k]
                );
                $list[] = $str;
        }
}

echo implode(' AND ', $list);

Cheers,
Fabian

answered May 23, 2010 at 16:39

halfdan

34.3k8 gold badges82 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ryan Over a year ago

This code is interesting. While it's combing all 4 statements into one, it looks like it's doing pretty much what I want. I'll manipulate a bit and see what happens. Thanks for cleaning up my code, too.

Tomalak · Accepted Answer · 2010-05-23 16:36:47Z

1

You never reset $where.

BTW. Don't do

if( !empty( $where ) )
$where .= ' AND ';
$where = "`".$columnnames[0]."` = ";

as this is dangerously ambiguous. Do

if( !empty( $where ) ) $where .= ' AND ';
$where = "`".$columnnames[0]."` = ";

or

if( !empty( $where ) ) {
  $where .= ' AND ';
}
$where = "`".$columnnames[0]."` = ";

answered May 23, 2010 at 16:36

Tomalak

339k68 gold badges547 silver badges635 bronze badges

Collectives™ on Stack Overflow

Use an Array to Cycle Through a MySQL Where Statement

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related