PHP delete key value pairs from array that have empty value

Question

I have post data that looks like this:

array(2) { 
    ["ui"]=> array(1) { 
        ["menu"]=> array(3) { 
            ["button1"]=> string(8) "Press me" 
            ["button2"]=> string(9) "Tickle me"
            ["button3"]=> string(0) ""

        }
    }
    ["messages"]=> array(1) { 
        ["status"]=> array(2) { 
            ["error"]=> string(0) "" 
            ["success"]=> string(0) ""
        }
    }
}

I want to remove all key, value pairs that have an empty value to get a result like this:

 array(1) { 
    ["ui"]=> array(1) { 
        ["menu"]=> array(2) { 
            ["button1"]=> string(8) "Press me" 
            ["button2"]=> string(9) "Tickle me"
        }
    }
}

So I implemented this recursive function:

function clear_empty_array_values($array){
    foreach($array as $key => $value){
        if (is_array($value)){
            clear_empty_array_values($value);  
        }else{
            if (empty($value)){
                unset($array[$key]);
            }  
        }
    }
}

But when I call this function on my array:

clear_empty_array_values($my_array);

I get the same result as before calling the method.

Can you see what is wrong?

AbraCadaver · Accepted Answer · 2015-02-17 16:43:52Z

1

To modify $my_array in place as you show, you need to pass-by-reference &. Then to modify $value in the foreach use a reference &:

function clear_empty_array_values(&$array){
    foreach($array as $key => &$value){
        if (is_array($value)){
            clear_empty_array_values($value);
        }
        if(empty($value)) {
            unset($array[$key]);
        }
    }
}

edited Feb 17, 2015 at 16:43

answered Feb 17, 2015 at 16:14

AbraCadaver

79.2k7 gold badges75 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Skullbox Over a year ago

Thanks! Added & to both the $array parameter and the $value variable, but it still shows the same for me, maybe is the array I send in that is wrong, updated my post with the actual data it gets. Sorry for the edit!

Skullbox Over a year ago

Ok now it works! Needed to remove the else so it removed empty arrays as well

AbraCadaver Over a year ago

OK, the logic looked sound but it would not remove the top-most array if empty. Edited.

degr · Accepted Answer · 2015-02-17 16:14:01Z

1

Do this one: function clear_empty_array_values(&$array)

or, you must return value:

function clear_empty_array_values($array){
    foreach($array as $key => $value){
        if (is_array($value)){
            $array[$key] = clear_empty_array_values($value);  
        }else{
            if (empty($value)){
                unset($array[$key]);
            }  
        }
    }
return $array;
}

answered Feb 17, 2015 at 16:14

degr

1,5651 gold badge19 silver badges42 bronze badges

Collectives™ on Stack Overflow

PHP delete key value pairs from array that have empty value

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related