Whats wrong with the following sqlite statement in android

Question

What is wrong with the following code? I get the following error

unrecognized token: "12345" (code 1): , while compiling: SELECT id, flag FROM myTable WHERE snumber=12345

String number = "12345";    
public static final String SNUMBER = "snumber";
public static final String ID = "id";
public static final  String FLAG = "flag";

String[] thecolumns = new String[] { ID, FLAG };

Cursor cursor = sqlDb.query(TABLE_NAME , thecolumns, SNUMBER+ "=" + number, null, null,   null, null);

Please format errors as code, rather than bolding, and give us an MCVE so we can understand what you're doing. — anon
– anon, Commented Feb 6, 2015 at 17:01
You've got minimal part covered. It's a simple value quoting problem, no need to include a whole android app in the post. — Seth Battin
– Seth Battin, Commented Feb 6, 2015 at 17:15

Jean-François Savard · Accepted Answer · 2015-02-06 16:58:31Z

1

This should work

Cursor cursor = sqlDb.query(TABLE_NAME , thecolumns, SNUMBER+ "='" + number+"', null, null,   null, null);

I added '' around number

answered Feb 6, 2015 at 16:58

Jean-François Savard

21k7 gold badges54 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

JourneyWithAndroid Over a year ago

Thanks worked .. never knew that there was a quote over there.

Emanuel · Accepted Answer · 2015-02-06 16:57:25Z

0

You should escape your data. using "?" for params is great. And you need to cast it to a String. Common way doing this when not using rawQuery is:

  Cursor cursor = sqlDb.query(TABLE_NAME , thecolumns, SNUMBER+ "=?", Integer.toString(number), null,   null, null);

answered Feb 6, 2015 at 16:57

Emanuel

8,1163 gold badges39 silver badges58 bronze badges

Collectives™ on Stack Overflow

Whats wrong with the following sqlite statement in android

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related