query inside query loop php

Question

This is my code:

include('connectTwo.html');

    $query = "select * from users";
    $result = mysql_query($query, $connectTwo);
    while($row = mysql_fetch_array($result))
    {
        echo $row['username'];
        $user_id = $row['user_id'];
        $profile = getProfile($user_id);
        echo $profile;

    }

    function getProfile($user_id)
    {
        $query = "select * from info where user_id='$user_id'";
        $result = mysql_query($query, $connectTwo);
        $row = mysql_fetch_assoc($result);
        $profile = $row['profile'];
        return $profile;
    }

The function doesn't return anything. I know that the query is correct because I move it outside the function and it runs and gives me the value I'm looking for. Please post a comment if you are confused about what I'm asking.

In a function - $result = mysql_query($query, $connectTwo); What is $connectTwo? — u_mulder
– u_mulder, Commented Jan 24, 2015 at 18:31
In the top of the script notice the include('connectTwo.html');. That file connects to my database and create the $connectTwo variable which I use for the queries. The query variables have the queries inside and then I execute them. — William Green
– William Green, Commented Jan 24, 2015 at 18:32
you need to pass the mysql connection string into the function — fortune
– fortune, Commented Jan 24, 2015 at 18:32
@u_mulder well, $query is defined in the line before as a string (in both cases) and $connectTwo obviously should be a resource. — arkascha
– arkascha, Commented Jan 24, 2015 at 18:33
Thank you - @fortune! It worked! Thank you so much. So I guess that the function couldn't use the global $connectTwo variable and it had to be passed in. thank you so much. Post an answer and I will vote it best! Thank you again. I have been stuck on this for a couple hours. — William Green
– William Green, Commented Jan 24, 2015 at 18:35

harrrrrrry · Accepted Answer · 2015-01-24 18:34:57Z

3

Try left join:

$query = "select a.*,b.profile from users a left join info b on b.user_id=a.user_id";

Then you can delete getProfile() function.

If you still want to use function getProfile($user_id), global $connectTwo in it otherwise you cant use it as it is undefined.

answered Jan 24, 2015 at 18:34

harrrrrrry

14.7k2 gold badges27 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fortune · Accepted Answer · 2015-01-24 18:43:35Z

1

You can try 2 methods:

Pass the database connection string as an argument to the function getProfile()

Like : getProfile($user_id, $connectTwo);

OR you can use global keyword to use the connection string inside function getProfile()

function getProfile($user_id) {
   global $connectTwo;

But above all the better approach has been pointed out by @zairwolf in the previous answer.

Note: Try to use mysqli_* or pdo * functions instead of mysql_* functions.

answered Jan 24, 2015 at 18:43

fortune

3,3721 gold badge23 silver badges30 bronze badges

Collectives™ on Stack Overflow

query inside query loop php

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related