Problems with an IF statement in JavaScript

Question

When I type in an ID number for the game, I always gets the 3rd statement of my if else expression. Where am I going wrong?!!

<html>
<body>
<p>Type in the ID and hit search:</p>
<button onclick="myFunction()">Search</button>
<p id="demo"></p>
    <form>
        <input id="textbox" type="text" />
    </form>
<script>
var textboxValue = document.getElementById("textbox").value;
function myFunction() {
    var message;
    if (textboxValue == 1) {
        message = "Fantasy World";
    } else if (textboxValue == 2) {
        message = "Sir Wags A Lot";
    } else {
        message = "Take a Path";
    }
document.getElementById("demo").innerHTML = message;
}
</script>
</body>
</html>

Denys Séguret · Accepted Answer · 2015-01-16 19:19:40Z

8

The problem is you always test the same, initial, value of the input.

Change

var textboxValue = document.getElementById("textbox").value;
function myFunction() {

to

function myFunction() {
    var textboxValue = document.getElementById("textbox").value;

This way the value will be read each time the function is called.

edited Jan 16, 2015 at 19:19

answered Jan 16, 2015 at 19:09

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Denys Séguret Over a year ago

Can the downvoter explain the problem in my answer ?

RickTicky Over a year ago

@dystroy Thank you dystroy. That's really helpful. People like you help newbies like me to improve and I am extremely grateful

Denys Séguret · Accepted Answer · 2015-01-16 19:11:54Z

4

Put this statement:

var textboxValue = document.getElementById("textbox").value;

Inside the function.

edited Jan 16, 2015 at 19:11

Denys Séguret

384k90 gold badges813 silver badges780 bronze badges

answered Jan 16, 2015 at 19:09

bayblade567

3762 silver badges11 bronze badges

1 Comment

Denys Séguret Over a year ago

I edited your answer to change the code formatting from a quote (you get this with ctrl-Q) to a code bloc (you get that with Ctrl-K).

Collectives™ on Stack Overflow

Problems with an IF statement in JavaScript

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related