while loop error in Java

Question

well im currently learning java my myself but from what i know i just cant seem to fix this problem currently testing a script where if u dont type ur name exactly u must re-type it but this error appears i searched everywhere but most of the things i tried dont work

Please type in your name: 
lucas
Welcome lucas
Confirm your name:
luca
Please type in your name: 
Exception in thread "main" java.util.NoSuchElementException: No line found
at java.util.Scanner.nextLine(Unknown Source)
at input.main(input.java:9)

here is the code:

import java.util.Scanner;

public class input {
    public static void main(String[] args) {

        while (true) {
            try (Scanner input = new Scanner(System.in)) {
                System.out.println("Please type in your name: ");
                String name = input.nextLine();
                System.out.println("Welcome " + name);
                if (name.equals("nico")) {
                    System.out.println("bitch");
                    break;
                } else {
                    System.out.println("Confirm your name:");
                    String name1 = input.nextLine();
                    if (name1.equals("nico")) {
                        System.out.println("Hello " + name1 + "... bitch");
                    } else if (name1.equals(name)) {
                        System.out.println("Thank you");
                        break;
                    }
                }
            }
        }
    }
}

What input did you use to get the output above? The NoSuchElementException is being raised because Scanner.nextLine() is not finding another line. — hhafez
– hhafez, Commented Jan 13, 2015 at 22:41

Sotirios Delimanolis · Accepted Answer · 2015-01-13 22:35:45Z

2

Move the try-with-resources to around your while loop. When execution leaves the try-with-resources, Java closes the resources. Here, that resource is the standard input, which cannot be re-opened.

try (Scanner input = new Scanner(System.in)) {
    while (true) {
        System.out.println("Please type in your name: ");

You actually don't really need the try-with-resources here. Don't close standard input/output/error.

answered Jan 13, 2015 at 22:35

Sotirios Delimanolis

281k62 gold badges718 silver badges744 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Daniel Figueroa Over a year ago

And now I learned something today! Documentationf for the interested: docs.oracle.com/javase/7/docs/api/java/util/…

lucas Over a year ago

wow i cant belive i didnt notice that... i feel dumb now but lets say i remove the try-with-resources and its left like this: Scanner input = new Scanner(System.in); while (true) { System.out.println("Please type in your name: "); the IDE tells me Resource leaked: the 'input' is never closed. unless i keep the try-with-resources

Sotirios Delimanolis Over a year ago

@lucas That's a warning. You can choose to ignore it. In this case, you should ignore it.

Has QUIT--Anony-Mousse · Accepted Answer · 2015-01-13 22:36:18Z

1

Don't put the Scanner into your loop.

Loop while the scanner still has input.

Currently, you create new Scanner too often.

answered Jan 13, 2015 at 22:36

Has QUIT--Anony-Mousse

77.8k14 gold badges146 silver badges198 bronze badges

Collectives™ on Stack Overflow

while loop error in Java

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related