Write data from file to struct on C

Question

I have a file from which I want to read data previously created by another program but I get an segmentation fault error. This is the programm.

typedef char Telemento[MAX_CHAR+5];

typedef struct{
   Telemento arraycola[NUM_ELEM];
   int inicio;
   int final;
}TCola;

typedef char TNombreImpresora[MAX_NOM_IMPR];

typedef struct{
   TNombreImpresora nombreimpresora;
   int numerodeficherosencola;
   TCola colaImpresora;
}TImpresora;

typedef struct{
   TImpresora impresora;
   int ocupado;
}TCelda;

typedef TCelda Tlistaimpresora[MAX_IMPR];



int main(){
    FILE *fp;
    int i=0;
    Tlistaimpresora listaimpresoras;



    fp=fopen("test.bin", "r");

    while(feof(fp)==0 && i<4){
       fread(&listaimpresoras[i].impresora, sizeof(listaimpresoras[i].impresora), (i+1), fp);
       listaimpresoras[i].ocupado=1;
       i++;
    }
    fclose(fp);


    return 0;   
}

Thanks for your time. If anyone needs more info please tell me.

Are you thinking 'i' is the file data pointer? Cf. stackoverflow.com/questions/10696845/… — dwn
– dwn, Commented Dec 27, 2014 at 21:57
the function call 'feof()' is only valid AFTER reading from the associated file. Much better to use the returned value from fread() to control the while loop\ — user3629249
– user3629249, Commented Dec 27, 2014 at 21:59
Please check the result of fopen if it fails it returns NULL and you still try to read from it. — Iharob Al Asimi
– Iharob Al Asimi, Commented Dec 27, 2014 at 22:04

kestasx · Accepted Answer · 2014-12-27 21:58:34Z

3

I think this line has an error (should be 1, not i+1):

fread(&listaimpresoras[i].impresora, sizeof(listaimpresoras[i].impresora), 1, fp);

answered Dec 27, 2014 at 21:58

kestasx

1,0918 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Iharob Al Asimi Over a year ago

You beat me by less than one second... +1.

kestasx Over a year ago

@iharob, just got tired of beeing beaten by You :)

Cypert Over a year ago

Thank you very much, now I understand better this function.

Iharob Al Asimi · Accepted Answer · 2014-12-27 21:59:02Z

3

Just change this

fread(&listaimpresoras[i].impresora, sizeof(listaimpresoras[i].impresora), (i+1), fp);

with this

fread(&listaimpresoras[i].impresora, sizeof(listaimpresoras[i].impresora), 1, fp);

you are not reading i + 1 items, just 1.

answered Dec 27, 2014 at 21:59

Iharob Al Asimi

53.1k6 gold badges66 silver badges100 bronze badges

Comments

Jasen · Accepted Answer · 2014-12-27 21:59:35Z

0

replace (i+1) with 1 in the fread call

also change [1] to [i]

what you have happening is each read getting bigger and the last read overflowing the array.

what you want is each read the same size into a different array element.

answered Dec 27, 2014 at 21:59

Jasen

12.5k2 gold badges37 silver badges50 bronze badges

Comments

Roh · Accepted Answer · 2014-12-28 15:35:33Z

0

This line:

fread(&listaimpresoras[i].impresora, sizeof(listaimpresoras[i].impresora), (i+1), fp);

is a bit odd for a couple of reasons:

1) your only reading one instance of the struct

2) the real sizeof should be the sizeof the struct, not the sizeof some array entry.

suggest:

fread(&listaimpresoras[i].impresora, sizeof(Tlistaimpresora), 1, fp);

Also, the code is very obfuscated by the messy typedef declarations All these typedef's will make the code much more complicated than necessary. just define one struct with the appropriate number of instances for each field (or group of fields)

edited Dec 28, 2014 at 15:35

Roh

1351 silver badge12 bronze badges

answered Dec 27, 2014 at 22:10

user3629249

16.6k1 gold badge18 silver badges17 bronze badges

Collectives™ on Stack Overflow

Write data from file to struct on C

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related