Java method to reverse every word in an array of strings

Question

I'm trying to make a method that will take an array of strings and return an array with all the words in reverse order but my code is not working.

When I run it i get "[Ljava.lang.String;@74122d9c"

Test case: String[]words={"Monday","Tuesday","Wednesday"}; -->{"yadnoM","yadsueT","yadsendeW"};

public String[] reverseString(String[] words)
{
    String[] t=new String[words.length];

    for(int i=0;i<words.length;i++)
    {
        for(int j=words[i].length()-1;j>=0;j--)
        {
            t[i]+=words[i].substring(j,j+1);
        }
    }
    return t;
}

Did you try using a for loop to iterate over the array and using a string builder str.reverse() method? that should work — Coding Enthusiast
– Coding Enthusiast, Commented Dec 12, 2014 at 4:09

camryn carrillo · Accepted Answer · 2021-05-18 06:05:54Z

When I run your code, I didn't get the same error that you posted, but I did notice that null was at the end of each reversed word.

nullyadnoM
nullyadseuT
nullyadsendeW

Which is beacuse when you create a new string array, all it's values default to null:

String[] t = new String[words.length];

The easiest way to fix it is to set it's value to an empty string, before you start adding to it:

public static String[] reverseString(String[] words)
{
    String[] text = new String[words.length];

    for (int i = 0; i < words.length; i++)
    {
        text[i] = "";
        for (int j = words[i].length() - 1; j >= 0; j--)
            text[i] += words[i].charAt(j);
    }
    return text;
}

I have tested this code, and it works perfectly fine for me.

To output the array, instead of using

System.out.println(words);

use the following:

System.out.println(Arrays.toString(words));

This will give you the output:

[yadnoM, yadseuT, yadsendeW]

Panther · Accepted Answer · 2018-04-13 10:55:38Z

2

You can transform your string into StringBuilder and it had reverse method. And its always better to use foreach rather than for, until there is actual need.

public String[] reverseString(String[] words) {
    String[] t = new String[words.length];
    for (String wordTemp : words) {
      StringBuilder sb = new StringBuilder(wordTemp);
      t[i] = sb.reverse().toString();   
    }
    return t;
}

Alternate approach :-

public  String[]  reverseString(String[] words)
{
    String[] t=new String[words.length];

    for(int i=0;i<words.length;i++)
    {   
        //added for setting elemennt as emptyString instead of null
        t[i] = "";
        for(int j=words[i].length()-1;j>=0;j--)
        {
            t[i]+=words[i].substring(j,j+1);
        }
    }

    //using loop
    for(int i=0;i<words.length;i++)
    {
         System.out.println(t[i]);
    }
    //using Arrays Method
    System.out.println(Arrays.toString(t));
    return t;
}

edited Apr 13, 2018 at 10:55

answered Dec 12, 2014 at 4:08

Panther

3,3499 gold badges31 silver badges52 bronze badges

3 Comments

Justin Over a year ago

We did not learn StringBuilder in my class, I don't think my teacher will let me use it

Panther Over a year ago

you can use any of approach to print array, Arrays is what we use, don't know if your teacher will let you use.

Mohamed Rimshad Over a year ago

where did that "i" in t[i] came from?

Scary Wombat · Accepted Answer · 2014-12-12 04:29:31Z

2

try using StringBuilder.reverse

public String[] reverseString(String[] words) {
        String[] t = new String[words.length];
        for (int i = 0; i < words.length; i++) {
            t[i]= new StringBuilder(words[i]).reverse().toString();
        }
        return t;
    }

Update

The fact that you are getting When I run it i get "[Ljava.lang.String;@74122d9c" is beccase you are printing the whole String array as one [Ljava.lang.String means String array. You will need to iterate over the array to print out the Strings one-by-one

edited Dec 12, 2014 at 4:29

answered Dec 12, 2014 at 4:07

Scary Wombat

44.9k6 gold badges38 silver badges67 bronze badges

8 Comments

Justin Over a year ago

We did not learn StringBuilder in my class, I don't think my teacher will let me use it

Scary Wombat Over a year ago

Why on earth not - it is in the java.lang package.

Emz Over a year ago

@ScaryWombat Why do one usually take classes? To learn things right? So the purpose of this assignment is not to reverse a string but to understand how one would do it?

Scary Wombat Over a year ago

@Emz Yeah I know that could be one lesson, another could be to learn that Strings are immutable. - See my update

Emz Over a year ago

Which is why he is returning a new string? Iterate backwards, copy over the value to the new, return. Voila.

|

Ankur Singhal · Accepted Answer · 2014-12-12 04:12:10Z

 public static void main(String[] args) {
        String[] words = { "Monday", "Tuesday", "Wednesday" };
        for (int i = 0 ; i < words.length ; i++) {
            words[i] = Reverse(words[i]);
        }
        for (int i = 0 ; i < words.length ; i++) {
            System.out.println(words[i]);
        }

    }

    private static String Reverse(String str) {
        StringBuilder result = new StringBuilder();
        StringTokenizer st = new StringTokenizer(str, "");
        while (st.hasMoreTokens()) {
            StringBuilder thisToken = new StringBuilder(st.nextToken());
            result.append(thisToken.reverse() + " ");
        }
        return result.toString();
    }

Output

yadnoM 
yadseuT 
yadsendeW

Also you can use org.apache.commons.lang3.StringUtils;, just to reduce your effort/shorten the code

private static String Reverse(String str) {
        return StringUtils.reverse(str);
    }

Ravi Durairaj · Accepted Answer · 2014-12-12 04:29:43Z

Below Code is working fine with the help Stringbuilder reverse function.

public class Example {

/**
 * @param args
 */
public static void main(String[] args) {
    // TODO Auto-generated method stub
    String[] irreverseStr = {"Monday","Tuesday","Wendesday","Thursday","Friday","Saturday","Sunday"};           
    String[] reverseStr = new Example().getReverseArray(irreverseStr);

    for(int j = 0; j < reverseStr.length; j++){
        System.out.println(reverseStr[j]);
    }           
}

public String[] getReverseArray(String[] str){      
    String [] reversestr = new String[str.length];      
    for(int i=0;i<reversestr.length;i++){
        reversestr[i] = new StringBuilder(str[i]).reverse().toString();
    }       
    return reversestr;
}

}

Arun Xavier · Accepted Answer · 2014-12-12 04:12:38Z

0

public static String[] reverseString(String[] words) {
    String[] t = new String[words.length];
    for (int i = 0; i < words.length; i++) {
        t[i]=new StringBuffer(words[i]).reverse().toString();

    }
    return t;
}

try StringBuffer's reverse method

answered Dec 12, 2014 at 4:12

Arun Xavier

7718 silver badges49 bronze badges

Comments

saeed eivazi · Accepted Answer · 2021-04-20 10:37:32Z

0

java 8+

public String[] reverseStringArray(String[] test){
       String[] result = Arrays.stream(test).map(item -> {
            List<String> list = Arrays.asList(item.split(""));
            Collections.reverse(list);
            return String.join("", list);
        }).collect(Collectors.toList()).toArray(new String[0]);
        return result;
}

answered Apr 20, 2021 at 10:37

saeed eivazi

9261 gold badge8 silver badges14 bronze badges

Collectives™ on Stack Overflow

Java method to reverse every word in an array of strings

7 Answers 7

Comments

3 Comments

8 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

3 Comments

8 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related