Grabbing from Javascript array

Question

So I am trying to create a variable that grabs the type_name from an array.

Here is my array.

var customIcons = {
        ItemI: {
            icon: 'http://...'
            type_name: 'East'
        },
        ItemII: {
            icon: 'http://...'
            type_name: 'West'
        },
        ItemIII: {
            icon: 'https:...'
            type_name: 'North'

        },
        question: {
            icon: 'https:...'
            type_name: 'South'

        }

}

Here is the variable I am trying to create. I know the php is passing in correctly, but I do not know why it is not grabbing the appropriate type_name from the array:

   var buttonText= customIcons[<?php echo $type; ?>].type_name;

I am getting a cannot read property 'type_name' of undefined when I try to use the variable.

Sincere thanks for any help! It is greatly appreciated.

That's because it's not an array, it's a JSON object. You'll need to use a JSON parse. — Scott
– Scott, Commented Dec 7, 2014 at 3:06
Yes, an object that is in JSOn format. Will want to use JSON.parse(text[, reviver]) developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/… — Scott
– Scott, Commented Dec 7, 2014 at 3:08
you are missing a comma after first field i.e. icon: {'http://...' ,type_name: 'East'} — user1428716
– user1428716, Commented Dec 7, 2014 at 3:15
@Scott: Is it just me, or is that not JSON? stackoverflow.com/questions/2904131/… — Qantas 94 Heavy
– Qantas 94 Heavy, Commented Dec 7, 2014 at 5:27
I am interested in the answer as well. Based on your reference question (@Qantas), it seems the single vs double quotes is the defining thing for this example. — ambe5960
– ambe5960, Commented Dec 7, 2014 at 5:40

baao · Accepted Answer · 2014-12-07 03:12:23Z

1

You need to rewrite it to

   var buttonText= customIcons['<?php echo $type; ?>'].type_name;

See the ' ' around <?php ?>, else it is parsed as a js variable

edited Dec 7, 2014 at 3:12

answered Dec 7, 2014 at 3:06

baao

73.5k18 gold badges152 silver badges208 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ambe5960 Over a year ago

Thanks a bunch, that was it. I don't know how I missed it, I had a similar line with the quotes right above it.

Roko C. Buljan Over a year ago

@ambe5960 remember (so you don't fall in the same trap again) [] = Array, {} = Object

orange · Accepted Answer · 2014-12-07 03:06:54Z

0

I think you forgot the quotes. var buttonText= customIcons['<?php echo $type; ?>'].type_name;

answered Dec 7, 2014 at 3:06

orange

8,25215 gold badges89 silver badges156 bronze badges

Comments

user1428716 · Accepted Answer · 2014-12-07 03:50:54Z

I don't know about PHP but here is what is wrong

Your JSON : You have a missing comma

var customIcons = {
        item1: {
            icon: 'http://...',
            type_name: 'East'
        },
        item2: {
            icon: 'http://...',
            type_name: 'West'
        },
        item3: {
            icon: 'https:...',
            type_name: 'North'

        },
        question: {
            icon: 'https:...',
            type_name: 'South'

        }
};

console.log(customIcons.item1.icon);

Then Your JSON structure is not ideal

It should have been

var customIcons = [


           {
                id:"item1",
                icon: 'http://...',
                type_name: 'East'
            },
            {
                id:"item2",
                icon: 'http://...',
                type_name: 'West'
            },
            item: {
                id:"item3",
                icon: 'https:...',
                type_name: 'North'

            },
           {
                id:"item4",  
                icon: 'https:...',
                type_name: 'South'

            }
]

Then you can parse this easily using for loop

Collectives™ on Stack Overflow

Grabbing from Javascript array

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related