Pushing values in an array through a loop in PHP [duplicate]

Question

I'm trying to push values in a 2D array through foreach loop, I get some strange results while doing so. Please take a look at the code:

   foreach( $terms as $term ) {
                if(is_parent_tax($term)==TRUE){
                 $parent_term = get_term( $term->term_id, $taxonomy_name );
                    if(!in_array($parent_term->name,$term_list)){
                    $term_list[]['name']  = $parent_term->name ;
                    $term_list[]['slug'] = $parent_term->slug;
                    }
                }
              }

Through a print_r test, I get the following results:

Array ( [0] => Array ( [name] => Category 2 ) [1] => Array ( [slug] => category-2 ) [2] => Array ( [name] => Category 3 ) [3] => Array ( [slug] => category-3 ) [4] => Array ( [name] => Category 4 ) [5] => Array ( [slug] => category-4 ) [6] => Array ( [name] => Category 2 ) [7] => Array ( [slug] => category-2 ) [8] => Array ( [name] => Category 1 ) [9] => Array ( [slug] => category-1 ) )

What I want instead, is:

Array ( [0] => Array ( [name] => Category 2 ) [0] => Array ( [slug] => category-2 ) [1] => Array ( [name] => Category 3 ) [1] => Array ( [slug] => category-3 ) [2] => Array ( [name] => Category 4 ) [2] => Array ( [slug] => category-4 ) [3] => Array ( [name] => Category 2 ) [3] => Array ( [slug] => category-2 ) [4] => Array ( [name] => Category 1 ) [4] => Array ( [slug] => category-1 ) )

zanderwar · Accepted Answer · 2014-11-29 12:39:05Z

2

Since no one explained why it didn't work.

Your usage of [] is incorrect. You're causing it to create another index. See Barth's answer although I would be using:

$term_list[] = array('name' => $parent_term->name, 'slug' => $parent_term->slug);

:)

answered Nov 29, 2014 at 12:39

zanderwar

3,7793 gold badges31 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Faizan Ali Over a year ago

Ahan!!! You are right, I tried Barth's code at the very first, and that gave me the results as [name]=>[slug]=>value, so wrapping all this stuff in an array(); did the trick. Thanks all of you for your support and effort!

zanderwar Over a year ago

Glad to have helped :)

Trevor Over a year ago

Definitely works! Only thing just to be clear for others looking at this, the (!in_array ...) part of the original question will not work as this is a multidimensional array. It's not really part of main question, but it tripped me up at first so just adding this for extra detail for others.

zanderwar Over a year ago

@Trevor php.net/manual/en/function.array-search.php have a look at the first user comment :)

Ronser · Accepted Answer · 2014-11-29 12:47:41Z

2

Just a small change to your foreach can do the trick

foreach( $terms as $key => $term ) {
    if(is_parent_tax($term)==TRUE){
     $parent_term = get_term( $term->term_id, $taxonomy_name );
        if(!in_array($parent_term->name,$term_list)){
            $term_list[$key]['name']  = $parent_term->name ;
            $term_list[$key]['slug'] = $parent_term->slug;
        }
    }
}

your

Array ( [0] => Array ( [name] => Category 2 ) [0] => Array ( [slug] => category-2 ) [1] => Array ( [name] => Category 3 ) [1] => Array ( [slug] => category-3 ) [2] => Array ( [name] => Category 4 ) [2] => Array ( [slug] => category-4 ) [3] => Array ( [name] => Category 2 ) [3] => Array ( [slug] => category-2 ) [4] => Array ( [name] => Category 1 ) [4] => Array ( [slug] => category-1 ) )

consists of duplicate keys which will be over written by other

The better way is to get it as

 Array
(
    [0] => Array
        (
            [name] =>  Category 2
            [slug] => category-2
        )

    [1] => Array
        (
            [name] =>  Category 3
            [slug] => category-3
        )
)

edited Nov 29, 2014 at 12:47

answered Nov 29, 2014 at 12:38

Ronser

1,8756 gold badges20 silver badges38 bronze badges

2 Comments

cjds Over a year ago

The problem is if they're not in the array they won't have a continuous progressive mapping of indices. But otherwise good answer +1

zanderwar Over a year ago

It's also better to promote "shorthand" PHP where applicable. Consolidation, organisation and efficiency is priority to going far in this industry.

Liglo App · Accepted Answer · 2014-11-29 12:35:43Z

1

$term_list[] = ['name' => $parent_term->Name, 'slug' => $parent_term->slug];

is the right way to go.

answered Nov 29, 2014 at 12:35

Liglo App

3,8494 gold badges32 silver badges55 bronze badges

Collectives™ on Stack Overflow

Pushing values in an array through a loop in PHP [duplicate]

3 Answers 3

4 Comments

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

2 Comments

Comments

Linked

Related