error with string list in C#

Question

Same namespace: 2 forms.

public class Account       //frm1
        {
            public string Username;
            public string Password;

        }

        public class ListAcc
        {
            public static List<Account> UserList;
        }

 private void button1_Click(object sender, EventArgs e)
        {

            List<Account> UserList = new List<Account>();
            Account acc = new Account();
            acc.Username = textBox1.Text;
            acc.Password = textBox2.Text;
            UserList.Add(acc);
        }

 private void button2_Click(object sender, EventArgs e)  //frm2
        {
            string p = frmDangky.ListAcc.UserList[0].Username; // null ->error
            string p = frmDangky.ListAcc.UserList[0].Password; // null ->error
        }

Someone help me? :( why my string is NULL???????? The textBox is not empty... Thanks!

Jay · Accepted Answer · 2010-04-24 00:55:11Z

2

In the button1_Click handler, you're creating a local variable UserList, instead of using the static member of ListAcc.

Try changing

List<Account> UserList = new List<Account>();

to

ListAcc.UserList = new List<Account>();

answered Apr 24, 2010 at 0:55

Jay

58.2k11 gold badges104 silver badges126 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gabe · Accepted Answer · 2010-04-24 01:09:44Z

1

You want something more like this:

    public class ListAcc 
    { 
        public static List<Account> UserList = new List<Account>();
    } 

    private void button1_Click(object sender, EventArgs e) 
    { 
        Account acc = new Account(); 
        acc.Username = textBox1.Text; 
        acc.Password = textBox2.Text; 
        ListAcc.UserList.Add(acc); 
    } 

    private void button2_Click(object sender, EventArgs e)  //frm2 
    { 
        string p1 = ListAcc.UserList[0].Username; // null ->error 
        string p2 = ListAcc.UserList[0].Password; // null ->error 
    }

answered Apr 24, 2010 at 1:09

Gabe

87.1k13 gold badges144 silver badges238 bronze badges

Comments

Foxfire · Accepted Answer · 2010-04-24 00:57:26Z

0

The code is a complete mess.

And your problem is not the textbox (because even if it would be empty the string would be "" but never null). Your problem is that the static UserList never gets set.

Moreover the compiler does warn about constructs like frmDangky.ListAcc.UserList. It warns for a reason, so please at least fix the warnings.

answered Apr 24, 2010 at 0:57

Foxfire

5,78524 silver badges30 bronze badges

Collectives™ on Stack Overflow

error with string list in C#

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related