Calling controller functions from the view in AngularJS

Question

I have a function in my BlogController which changes the height of a div.

$scope.setTopBackgroundHeight = function (screenProportion, targetDiv) {
  globalService.setTopBackgroundHeight(screenProportion, targetDiv);
};

I am using this controller on a few pages, but only want to call this function on one page. So I put the call in my view as follows.

<div id="primary" 
     class="content-area blog-page" 
     ng-controller="blogCtrl">
     {{$scope.setTopBackgroundHeight("half", ".background-container");}}
</div>

Now, this works. But is calling a function from within curly braces in the view ok to do style wise? I've tried to find examples of doing something like this in the angular way, but can't see anything. Should it be in some ng directive?

Wawy · Accepted Answer · 2014-11-15 22:52:29Z

1

Yes, all DOM manipulation should be done inside directives. So In this case it'd be better if you had a directive attached to the div that called that service method.

HTML:

<div id="primary" 
     class="content-area blog-page" 
     ng-controller="blogCtrl"
     setBGHeight>
</div>

JS:

app.directive('setBGHeight', function(globalService) {
  return {
    link: function() {
      globalService.setTopBackgroundHeight("half", ".background-container");
    }
  }
));

answered Nov 15, 2014 at 22:52

Wawy

6,2692 gold badges26 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

doog abides Over a year ago

still rather wrong. probably a good place for ng-class or ng-style

Wawy Over a year ago

I don't know what the actual service does so I'm not questioning if he should be using a service or not since he didn't ask for that.

Paul Byrne Over a year ago

I get it, thanks. Yeah that's what I wanted to know, the best way to apply functions. Cheers

doog abides Over a year ago

Yeah, I have a feeling he's not using angular in any way it ought to be. But whether it gets called from a controller or directive, you probably shouldn't be setting DOM in a service...

Paul Byrne Over a year ago

@doog - the function I am calling checks the height of the window and then sets the div with the background to that height. What would be a better approach to achieving this without using a directive?

|

jsSn0wMan · Accepted Answer · 2014-11-15 23:00:25Z

0

This is what directives are for. Make sure to prefix them like angular does with "ng-click" but don't use ng.

answered Nov 15, 2014 at 23:00

jsSn0wMan

31 bronze badge

Collectives™ on Stack Overflow

Calling controller functions from the view in AngularJS

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related