Finding Smallest Number in An Array errors

Question

I'm trying to find the smallest number in a array of 1000 possible slots but my code keeps returning 0 even though 0 is not one of my inputs. My problem is in the last for loop, the rest of the code works. Here is my code:

import java.util.ArrayList;
import java.util.InputMismatchException;
import java.util.Scanner;
public class SmallestNumber
{

    public static boolean isInteger(String num)
    {
        boolean again=false;
        try 
        { 
            int d= Integer.parseInt(num); 
            again=true;
        } 
        catch(NumberFormatException e)
        { 
            again=false; 
        }
        return again;   
}
public static void main(String[] args) 
{

    int [] intNum = new int[1000];
    int i=0;
    String num;
    boolean repeat = false;
    String done="done";
    Scanner inData = new Scanner(System.in);
    System.out.println("You can enter up to 1000 integers." + "\n" + "Enter 'done' to finish");

        while (!repeat)
        {
            System.out.print("Int: ");
            num=inData.next();
            repeat=isInteger(num);


            if (repeat==false)
                {   
                    String entry=num.toUpperCase();
                    boolean equals=entry.equals("DONE");

                            if (equals==true)
                                {
                                    repeat=true;
                                }
                            else
                                {
                                    System.out.println("Error: you did not enter a valid chracter. Please enter a interger or state 'done'");
                                    repeat=false;
                                }

                }
            else
                {
                    int number=Integer.parseInt(num);
                    intNum[i]=number;
                    i=i+1;
                    if(i<1000)
                        {
                            repeat=false;
                        }
                    else
                        {
                            repeat=true;
                        }
                }

        }       


                int temp=intNum[0];
                for(int j=1;j<intNum.length;j++)
                {

                    if (intNum[j]<temp)
                    {

                intNum[j]=temp;
                    }
                    else
                    {

                    }
                }

            System.out.print(temp);

        }


}

Look at this line - intNum[j]=temp; and explain to me what it's doing. Then change it to what it's supposed to be. — Dawood ibn Kareem
– Dawood ibn Kareem, Commented Nov 13, 2014 at 23:08
Also, you have variables called i, num, number, temp and intNum. How can you possibly keep track of what each one is for? Please use more informative names for all your variables. — Dawood ibn Kareem
– Dawood ibn Kareem, Commented Nov 13, 2014 at 23:10
It sets the value of temp to the array value at j? (Sorry if this seems elementary, I'm a beginner....) — OoOoOoOoOoO
– OoOoOoOoOoO, Commented Nov 13, 2014 at 23:10
Are you sure it sets the value of temp to something? What usually happens if you write something like a = 5; ? — Dawood ibn Kareem
– Dawood ibn Kareem, Commented Nov 13, 2014 at 23:11

brycem · Accepted Answer · 2014-11-13 23:15:31Z

1

You didn't say how many integers you are actually entering, but the problem is that you're iterating intnum.length times. You've declared your input fields as an array of 1000 elements, length will always be 1000 even if the user has entered fewer integers than that. Once your code has flown past the integers you actually entered, it's going to hit the initialized 0s of the array.

answered Nov 13, 2014 at 23:15

brycem

6034 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

OoOoOoOoOoO Over a year ago

That makes sense, is there a way to set the length of the for loop to only the initialized elements of the array?

brycem Over a year ago

There is not. The array is just 1000 integers to Java, so the initial zeros are just as valid to it as your data entry. You'll have to keep track of how many valid entries you recorded, which it looks like you're doing with the i variable already.

OoOoOoOoOoO · Accepted Answer · 2014-11-13 23:26:33Z

0

Hi I solved the problem by changing the length of the ending for loop to i and switching

intNum[j]=temp;

to

temp=intNum[j];

Thanks again

answered Nov 13, 2014 at 23:26

OoOoOoOoOoO

1313 silver badges10 bronze badges

Comments

hfontanez · Accepted Answer · 2014-11-14 00:16:33Z

0

The process:

Prompt user
Validate input: IF input NaN skip, ELSE add to ArrayList of Integers
Sort array list in ascending order
Value at index 0 is the smallest

Everything else in your that doesn't fit this process is either out of place or not needed.

UPDATE:

public static void main(String[] args)
{
    List<Integer> numbers = new ArrayList<Integer>(1000);
    Scanner inData = new Scanner(System.in);
    System.out.println("You can enter up to 1000 integers." + "\n"
            + "Enter 'done' to finish");
    String input = "";
    do
    {
        input = inData.next();
        try
        {
            numbers.add(Integer.parseInt(input));
        }
        catch(NumberFormatException e)
        {
            System.out.println(input + " is not a number. Skipping...");
        }
    } while (!input.equalsIgnoreCase("done"));

    Collections.sort(numbers);

    inData.close();
    System.out.println("Smallest number: " + numbers.get(0));
}

This does exactly what the title suggest without all the extras. It was suggested by David Wallace that might be overkill. I am not sure it is. Don't have time to benchmark. I have to pack for a trip tomorrow. Maybe someone could comment on it.

edited Nov 14, 2014 at 0:16

answered Nov 13, 2014 at 23:26

hfontanez

6,2082 gold badges29 silver badges43 bronze badges

1 Comment

Dawood ibn Kareem Over a year ago

Sorting the array seems overkill to me. You only need one pass through it to find the lowest number. The OP's original algorithm is more efficient than this - he/she just had a couple of small mistakes in the implementation of it.

Collectives™ on Stack Overflow

Finding Smallest Number in An Array errors

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related