bash nested for loop not working

Question

I've written a bash script to ban country IP blocks from my router.

Why is it that the following works:

for ip in $(wget -qO- http://ipdeny.com/ipblocks/data/countries/cn.zone)
do 
    iptables -I wanin -s "$ip" -j DROP
done

But the following in which I nest multiple countries does not?

for country in CN AD
do 
    for ip in $(wget -qO- http://ipdeny.com/ipblocks/data/countries/$country.zone) 
    do 
        iptables -I wanin -s "$ip" -j DROP
    done
done

SMA · Accepted Answer · 2014-11-08 15:15:10Z

3

See that it's case sensistive. You have

for country in CN AD;

See that you are using caps here. If you use

for country in cn ad;

Then it should work. Try out yourself the link not working upper case zone and working with lower case zone

answered Nov 8, 2014 at 15:15

SMA

37.2k8 gold badges53 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

gniourf_gniourf · Accepted Answer · 2014-11-08 18:38:42Z

1

Since country is expected to be lowercase you may add declare -l country like this:

declare -l country
for country in CN AD; do 
  for ip in $(wget -qO- http://ipdeny.com/ipblocks/data/countries/$country.zone); do
    iptables -I wanin -s "$ip" -j DROP
  done
done

or use the ${var,,} parameter expansion:

for country in CN AD; do 
  for ip in $(wget -qO- http://ipdeny.com/ipblocks/data/countries/${country,,}.zone); do
    iptables -I wanin -s "$ip" -j DROP
  done
done

edited Nov 8, 2014 at 18:38

gniourf_gniourf

47.4k10 gold badges105 silver badges113 bronze badges

answered Nov 8, 2014 at 17:41

Edouard Thiel

6,36830 silver badges35 bronze badges

Collectives™ on Stack Overflow

bash nested for loop not working

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related