HttpClient to retrieve web API response

Question

I want a generic function that will send a http request & returns a HttpResponseMessage. Here is what I got now.

        public static HttpResponseMessage SendRequest(string actionUri, string baseAddress, HttpRequestMessage request)
    {
        using (var client = new HttpClient())
        {
            client.BaseAddress = new Uri(baseAddress);

            HttpResponseMessage response = null;

            foreach (var header in request.Headers)
            {
                client.DefaultRequestHeaders.Add(header.Key, header.Value);
            }

            if (request.Method == HttpMethod.Get)
            {
                response = client.GetAsync(actionUri).Result;
            }

            if (request.Method == HttpMethod.Post)
            {
                response = client.PostAsync(actionUri, request.Content).Result;
            }

            if (request.Method == HttpMethod.Put)
            {
                response = client.PutAsync(actionUri, request.Content).Result;
            }

            if (request.Method == HttpMethod.Delete)
            {
                response = client.DeleteAsync(actionUri).Result;
            }
            return response;
        }
    }

Above function can be written as below

    public static HttpResponseMessage SendRequest1(string actionUri, string baseAddress, HttpRequestMessage request)
    {
        using (var client = new HttpClient())
        {
            client.BaseAddress = new Uri(baseAddress);
            return client.SendAsync(request).Result;

        }
    }

Is there any issues using the second approach versus the explicit calls based on the http verb. For some requests I am getting error for GET requests as "Cannot send a content-body with this verb-type"

C.Evenhuis · Accepted Answer · 2014-10-13 10:18:02Z

1

The second piece of code looks fine to me; GET requests should never contain a content-body.

In the first example you're ignoring the content-body in case of a GET request, in the second example you're letting the framework throw an exception (which it was designed to do).

answered Oct 13, 2014 at 10:18

C.Evenhuis

26.4k2 gold badges60 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

HttpClient to retrieve web API response

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related