Why isn't my JavaScript variable working?

Question

This works:

$('.sameDiv').css('width', '25%');

But this doesn't:

var squaresize = 25;
$('.sameDiv').css('width', 'squaresize%');

Also, I've tried it with the percent symbol as part of the variable and that doesn't help.

What made you think JavaScript would substitute variable names in strings? Given var foo = 42; did you think that var bar = 'foobar'; would be turned into '42bar'? — Felix Kling
– Felix Kling, Commented Oct 13, 2014 at 1:08
possible duplicate of JavaScript adding a string to a number — ProllyGeek
– ProllyGeek, Commented Oct 13, 2014 at 1:16
For things that are JQuery + Javascript, it's often better to use JQuery in the title instead of Javascript, to get the right folks to answer. — Dean J
– Dean J, Commented Oct 27, 2014 at 0:05

Michael Voznesensky · Accepted Answer · 2014-10-13 01:02:41Z

5

$('.sameDiv').css('width', 'squaresize%');

Should become

$('.sameDiv').css('width', squaresize + '%');

I did not test it, but if you just put 'squaresize%' it will not try to reference it... rather, just read it directly as a literal string evaluating to "squaresize%" instead of 25%

edited Oct 13, 2014 at 1:02

answered Oct 13, 2014 at 0:54

Michael Voznesensky

1,61612 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bergi Over a year ago

Please wrap .sameDiv in string delimiters…

Peter Mortensen · Accepted Answer · 2014-10-26 01:51:39Z

1

Your code should be like:

var squaresize = 25;

$(".sameDiv").css('width', squaresize+'%');

Your variable name is "squaresize". Knowing that when adding a string to an integer will produce a string as well, there is no need to convert your integer to a string. Just add the "%" to your variable value.

Using a single quote, you are setting css to value 'square%' as a static value.

edited Oct 26, 2014 at 1:51

Peter Mortensen

31.4k22 gold badges110 silver badges134 bronze badges

answered Oct 13, 2014 at 0:54

ProllyGeek

15.9k9 gold badges56 silver badges77 bronze badges

5 Comments

Michael Voznesensky Over a year ago

Please do not post solutions, but explain why as well!

ProllyGeek Over a year ago

@MichaelVoznesensky but you are right concerning explaining.

Steven Over a year ago

Per Bergi's comment in the other answer: Please wrap .sameDiv in string delimiters…

Felix Kling Over a year ago

@ProllyGeek: FYI, the downvote tooltip text says "This answer is not useful". An answer can contain a correct solution but may not be useful.

ProllyGeek Over a year ago

@FelixKling thanks for the information , but useful is not a digital value , it may vary from person to another such question doesnt really require answering i would flag it as noob question if there was such option.

Collectives™ on Stack Overflow

Why isn't my JavaScript variable working?

2 Answers 2

1 Comment

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related