Create single variable from while loop

Question

I am trying to place a while loop into a variable that I can use as a single echo. What is happening is that the loop is only displaying the first record.

All db connections are in place and connected. I would appreciate it if someone could point out my error. Many thanks

if (mysql_num_rows($result1) >0) {
    $msgread = "";
    while($row = mysql_fetch_array($result1)) { 
        $msgread = "<FONT COLOR='1d99f0'>" . "<b>" . $row['to_user'] . "</b>" . "</font>";
        $msgread .= "<p />";
        $msgread .= date("d/m/Y");
        $msgread .= "<p />";
        $msgread .= $row['message'];
        $msgread .= "<p />";
        $msgread .= $row['from_user'];
    }

    $error1 = false;
}

if($error1 == 0)  {     
    echo $msgread;               
}

You have a closing bracket at the end of the msgread attribution. Identation matters here, don't avoid it. Could it be that? — Fernando Aires
– Fernando Aires, Commented Sep 20, 2014 at 11:03
You can store them in array and than run the foreach loop? if its ok — arif_suhail_123
– arif_suhail_123, Commented Sep 20, 2014 at 11:03
db query returns all records. Do you have example arif. Thanks — user1532468
– user1532468, Commented Sep 20, 2014 at 11:11

Salini L · Accepted Answer · 2014-09-20 11:17:19Z

1

Use . in the while loop's first line
$msgread .= "" . "" . $row['to_user'] . "" . "";

answered Sep 20, 2014 at 11:17

Salini L

8796 gold badges15 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kevin · Accepted Answer · 2014-09-20 11:22:53Z

1

You are overwriting it each loop, it should be .=:

$msgread = "";

while($row = mysql_fetch_array($result1)) {

   $msgread = "<FONT COLOR='1d99f0'>" . "<b>" . $row['to_user'] . "</b>" . "</font>";
            ^^ it gets overwritten each loop

Should be like:

if (mysql_num_rows($result1) >0) {

    $msgread = ""; // initialize

    while($row = mysql_fetch_assoc($result1)) {

        $msgread .= "<FONT COLOR='1d99f0'><b>" . $row['to_user'] . "</b></font>";
              // ^ concatenation
        $msgread .= "<p>" . date("d/m/Y") . '</p>';
        $msgread .= "<p>" . $row['message'] . '</p>';
        $msgread .= "<p>" . $row['from_user'] . '</p>';           
    }

    echo $msgread; // then echo

}

edited Sep 20, 2014 at 11:22

answered Sep 20, 2014 at 11:15

Kevin

41.9k12 gold badges57 silver badges72 bronze badges

Comments

Avinash Babu · Accepted Answer · 2014-09-20 11:52:07Z

0

You have missed . on the line $msgread = "" . "" . $row['to_user'] . "" . "";

It would be $msgread .= "" . "" . $row['to_user'] . "" . "";

answered Sep 20, 2014 at 11:52

Avinash Babu

6,2534 gold badges23 silver badges26 bronze badges

Collectives™ on Stack Overflow

Create single variable from while loop

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related