Php Mysql NOT IN array only affecting first result in array

Question

So I have a query to create an array of ID's that I do not want to be included in the data that populates my Select List. Both the select list and the array of excluded ID's are being pulled from a mysql database. The problem I am having is that when I echo out $exclude, it appears correctly in a comma separated list (1,2,3). However, when I attempt to add it in my NOT IN statement, it is only excluding the first number. I need it to exclude the entire array. Any ideas?

<?php
$excludeSql = "SELECT member_id FROM appointments WHERE joint_id = '$jointid'";
$excludeData = mysql_query($excludeSql, $link);
while($excluderow = mysql_fetch_array($excludeData)){

    $excludearray[] = $excluderow['member_id'];

                              }
$exclude = implode(',',$excludearray);
echo $exclude;
?>
<select name="attendees[]">             
    <option value="">--Select--</option>

        <?php 
        $memberSql = "SELECT id, firstName, lastName FROM members WHERE id NOT IN('".$exclude."') && compid = '$compid' ORDER BY lastName ASC";
        $memberResult = mysql_query($memberSql, $link);
            while($memberRow = mysql_fetch_assoc($memberResult)){?>
                <option value="<?php echo $memberRow['id'];?>" ><?php echo "".$memberRow['lastName'].", ".$memberRow['firstName'].""; ?></option>
        <?php } ?>              
</select>

Life would be so great if MySQL worked that way. It will only take the first value of the array. You'd need a OR NOT IN(or several for that matter) in your query. — Andrei P.
– Andrei P., Commented Sep 2, 2014 at 20:53

Ende Neu · Accepted Answer · 2014-09-02 20:55:14Z

5

You don't need the quote here:

WHERE id NOT IN('".$exclude."')
                ^            ^

Also you could achieve the same result in one query:

SELECT 
  id, 
  firstName, 
  lastName 
FROM members 
WHERE id NOT IN
  (SELECT 
     member_id 
   FROM appointments 
   WHERE joint_id = '$jointid')

answered Sep 2, 2014 at 20:55

Ende Neu

15.8k5 gold badges61 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ende Neu Over a year ago

@doublesharp I don't agree with you, the implode is wrapped in quotes ending up with '1,2,3', you can easily try it here.

Paige Rose Figueira Over a year ago

It worked when I just added the second SELECT statement into the NOT IN clause. Thanks!!

Marc B · Accepted Answer · 2014-09-02 20:55:00Z

3

You quoted your exclude IDS, so you've turned that comma separated list of numbers into a monolithic string:

WHERE id NOT IN ('1,2,3,4')
WHERE id NOT IN (1,2,3,4)

The above two are two completely DIFFERENT statements. One is a single string, which makes it the equivalent of id <> '1,2,3,4'. The other is a list of 4 numbers for the IN operation.

answered Sep 2, 2014 at 20:55

Marc B

362k44 gold badges433 silver badges508 bronze badges

6 Comments

doublesharp Over a year ago

This is not the issue, the explode will account for this.

Marc B Over a year ago

what explode? There's only an implode in there. And what's the matter with the while loop? The indenting is crap, but the loop itself is valid.

doublesharp Over a year ago

Sorry, I meant implode - it is using ',' for the glue.

Marc B Over a year ago

So? That has nothing to do with the fact taht those comma-separated values then get quoted with ' when used in the actual query string.

doublesharp Over a year ago

And you are correct about the while loop - didnt see the closing curly brace hanging out there.

|

Collectives™ on Stack Overflow

Php Mysql NOT IN array only affecting first result in array

2 Answers 2

2 Comments

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related