Angularjs variable undefined outside of function

Question

Whenever I call the cardslength variable or just cards.length, I get undefined outside of the function. Does this mean I need to use $scope? I am using angular 1.0.5 btw because this is part of a tutorial I am following and I needed to use that version.

This is my code:

eventsApp.factory('eventData', function ($resource, $q) {
var resource = $resource('/data/event/:id', {id: '@id'});


//////////////////////This is the part that doesn't seem to be working//////////
var cardslength
var cards = resource.query(function() {
        cardslength = cards.length;
        });
        console.log(cardslength);
        console.log(cards.length);
////////////////////////////////////////////////////////////////////////////////


return {
    getEvent: function () {
        var deferred = $q.defer();
        resource.get({id: 1},
            function (event) {
                deferred.resolve(event);
            },
            function (response) {
                deferred.reject(response);
            });

        return deferred.promise;
    },
    save: function(event) {
        var deferred = $q.defer();
        event.id = 1234;
        resource.save(event,
            function(response) { deferred.resolve(response);},
            function(response) { deferred.reject(response);}
        );
        return deferred.promise;
    }
};
});

That means resource.query() does not return anything, or your callback is execute before something is returned, overall bad service implementation — Ahmad
– Ahmad, Commented Aug 27, 2014 at 10:16
Before the function its just defined but has undefined, logical, where else do you access it and it doesn't work? also remember cardslength will have a value only when query() finishes execution — Ahmad
– Ahmad, Commented Aug 27, 2014 at 10:20
console.log(cardslength); console.log(cards.length); Are both not working when I request them after the function but they work when I put them inside of the resource.query function — user1442232
– user1442232, Commented Aug 27, 2014 at 10:25
Yes in that case its still undefined because .query() did not finish execution, so your console.log() is excuted before query() finishes. — Ahmad
– Ahmad, Commented Aug 27, 2014 at 10:26

khemry · Accepted Answer · 2014-08-27 10:30:37Z

1

Your console.log is executed before the .query() finishes. In order to avoid this, try as follows:

var cards = resource.query(function() {
    cardslength = cards.length;
}).then(function(){
    console.log(cardslength);
    console.log(cards.length);
});

answered Aug 27, 2014 at 10:30

khemry

5853 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user1442232 Over a year ago

That also gets me undefined.

khemry Over a year ago

Actually, it's not working because you are using Angular 1.0.5. The above answer is only working with Angular 1.1.3 and later.

user1442232 Over a year ago

Acteally I just found out that in the latest Angularjs you need to use .$promise.then(){};

Collectives™ on Stack Overflow

Angularjs variable undefined outside of function

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related