Regex to remove url parameter

Question

I'm having trouble writing a regex that removes any of these parameters from a url using javascript:

pricerange=-#

pricerange=#-#

pricerange=#-

This works ok for all except the last one. It doesn't remove pricerange=40-

var postUrl = "http://www.test.com/directory/?cat=203604&pricerange=-10&pricerange=10-20&pricerange=20-30&pricerange=30-40&pricerange=40-" 

postUrl = postUrl.replace(/[&\?]\bpricerange\=[0-9]*-[0-9]*\b/g, "");

Result:

http://www.test.com/directory/?cat=203604&pricerange=40-

Expected result:

http://www.test.com/directory/?cat=203604

Here is the jsbin.

There could be other parameters in the url that I wouldn't want to remove.

Braj · Accepted Answer · 2014-08-14 19:35:28Z

5

Try it again after removing ending \b

online demo

OR use (\b|$) to match either word boundary or end of the line

Corrected online demo

Your regex will not work correctly if cat=203604 is some where in between pricerange query parameters.

for example:

http://www.test.com/directory/?pricerange=-10&cat=203604&pricerange=10-20&pricerange=20-30&pricerange=30-40&pricerange=40-

Output: (Query parameter should be started by ?)

http://www.test.com/directory/&cat=203604

You can correct it, using &*\bpricerange\=[0-9]*-[0-9]*&*

Here is online demo

edited Aug 14, 2014 at 19:35

answered Aug 14, 2014 at 17:26

Braj

46.9k5 gold badges63 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Paul Roub Over a year ago

Specifically voting up the second version. Also, no need for the \b after the [&\?], so: /[&\?]pricerange\=[0-9]*-[0-9]*(\b|$)/g

Braj Over a year ago

Yes you are right. No need to use \b because [&\?] is already defined as prefix

Braj Over a year ago

@PaulRoub \b is needed. Look at the updated post. There is one more fault in OP regex patern.

user3203928 Over a year ago

I guess the only issue is if the url is this "test.com/directory/?pricerange=10-20" then the '?' stays there.

user3203928 Over a year ago

Sorry, still not there. This one doesn't work: test.com/directory/?pricerange=-10&pricerange=10-20

|

Paul Roub · Accepted Answer · 2014-08-14 19:36:25Z

1

Does it have to be a regular expression? We're going through a lot of gymnastics to make that happen. A function would do the job:

function cleaner(url)
{
  var parts = url.split("?");

  if (parts.length == 2)
    {
      var comps = parts[1].split('&');

      for ( var i = comps.length - 1; i >= 0; --i )
        {
          if (comps[i].match(/^pricerange=\d*\-\d*$/))
            comps.splice(i, 1);
        }

      if (comps.length > 0)
        parts[1] = comps.join('&');
      else
        parts.splice(1, 1);
    }

  return parts.join("?");
}

var postUrl = "http://www.test.com/directory/?cat=203604&pricerange=-10&pricerange=10-20&pricerange=20-30&pricerange=30-40&pricerange=40-" 

postUrl = cleaner(postUrl);

Example: http://codepen.io/paulroub/pen/srfCj

answered Aug 14, 2014 at 19:36

Paul Roub

36.5k27 gold badges88 silver badges95 bronze badges

1 Comment

user3203928 Over a year ago

Thank you. Also a good suggestion. Probably easier to maintain.

Collectives™ on Stack Overflow

Regex to remove url parameter

2 Answers 2

8 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related