Angularjs injecting factory with http to a controller

Question

I keep getting errors while injecting a factory in to a controller. It worked in a case where the controller is simple. It fails when the page and the controller has special components like ng-flow or ng-grid.

var carouselController = carouselApp.controller('carouselController', ['CMSFactory', function ($scope,CMSFactory) {

// MY CODE HERE...

}
var CMSServices = angular.module('api.services', [ 'ngResource' ]);

CMSServices.factory('CMSFactory', function($http, $q) {
    var CMSService = {};

    CMSService.saveSiteInfo = function(data) {

    // MY CODE HERE...

    };

    CMSService.addSlide = function(data) {

    // MY CODE HERE...

    };

    return CMSService;
});

I get TypeError: undefined is not a function error. If I remove the factory injection code works fine.

Appreciate any help...

tymeJV · Accepted Answer · 2014-08-13 20:37:58Z

1

You're not declaring $scope in your array of dependencies:

Change:

var carouselController = carouselApp.controller('carouselController', ['CMSFactory', function ($scope,CMSFactory) {

To:

var carouselController = carouselApp.controller('carouselController', ['$scope', 'CMSFactory', function ($scope,CMSFactory) {

answered Aug 13, 2014 at 20:37

tymeJV

105k14 gold badges165 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DwarakaT Over a year ago

That fixed the issue... I wan't expecting it to be that simple after looking through all blogs for couple of hours... Thanks,

Collectives™ on Stack Overflow

Angularjs injecting factory with http to a controller

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related