Sorting ArrayList not affecting to ArrayList

Question

I am trying to sort ArrayList on the basis of String actually I have numbers in "", like this: "4000"

I have written code to sort arraylist on the basis of price, but whenever i do tap on button it is not affecting to my ListView... why ?

I am following this tutorial....

This is how my JSON looks:

{
"locations": [
{
"name": "Office",
"price": "4,00,000"
},
{
"name": "Work",
"price": "1,20,000"
}
]
}

Model class:

public class Locations {

    private String name;
    private String price;

    public Locations() {
        // TODO Auto-generated constructor stub
    }

    public Locations(String name, String price) {
        super();
        this.name = name;
        this.price = price;
    }


    public String getName() {
        return name;
    }

    public void setName(String name) {
        this.name = name;
    }

    public String getPrice() {
        return price;
    }

    public void setPrice(String price) {
        this.price = price;
    }

}

LocationsActivity.java:

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_locations);
    actorsList = new ArrayList<Locations>();
    new JSONAsyncTask().execute(" ");

    listview = (ListView) findViewById(R.id.list);
    adapter = new LocationsAdapter(getApplicationContext(), R.layout.adapter_locations, actorsList);

    btnHTL = (Button) findViewById(R.id.btnHTL);
    btnHTL.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {
            Collections.sort(actorsList, new Comparator<Locations>(){
                  public int compare(Locations obj1, Locations obj2)
                  {
                      // ascending
                      return (Integer)(arg1.price).compareTo(arg2.price);
                  }
                });
            }
        }); 

    btnLTH = (Button) findViewById(R.id.btnLTH);
    btnLTH.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {
            Collections.sort(actorsList, new Comparator<Locations>(){
                  public int compare(Locations obj1, Locations obj2)
                  {
                      // descending
                      return (Integer)(arg2.price).compareTo(arg1.price);
                  }
                }); 
            }
        });
}

So what's the question? I don't get what you're trying to do. By reading your code the first thing i would suggest you is to process the result in your onPostExecute, not in your doInBackground, just left doInBackground for background network operations — Sherekan
– Sherekan, Commented Aug 11, 2014 at 9:16
how to filter records - simply want to show records based on price High to Low and Low to High — Sun
– Sun, Commented Aug 11, 2014 at 9:17
I believe this might help mkyong.com/java/… You have to define an order to your array based on what it contains and what you want to order, so you can sort it by using the sort() function — Sherekan
– Sherekan, Commented Aug 11, 2014 at 9:21

KOTIOS · Accepted Answer · 2014-08-11 12:40:28Z

1

public class MainActivity extends Activity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        Button asc = (Button) findViewById(R.id.asc);
        Button desc = (Button) findViewById(R.id.desc);
        final ArrayList<Location> actorsList = new ArrayList<Location>();

        Location loc = new Location();
        loc.setName("1");
        loc.setPrice("4000");
        actorsList.add(loc);

        loc = new Location();
        loc.setName("2");
        loc.setPrice("8000");
        actorsList.add(loc);

        loc = new Location();
        loc.setName("3");
        loc.setPrice("1000");
        actorsList.add(loc);

        loc = new Location();
        loc.setName("4");
        loc.setPrice("16000");
        actorsList.add(loc);

        asc.setOnClickListener(new OnClickListener() {

            @Override
            public void onClick(View v) {
                // TODO Auto-generated method stub
                Collections.sort(actorsList, new Comparator<Location>() {
                    @Override
                    public int compare(Location arg1, Location arg2) {
                        Integer obj1 = new Integer(arg1.getPrice().replace(",",""));
                        Integer obj2 = new Integer(arg2.getPrice().replace(",",""));
                        return (Integer) (obj1).compareTo(obj2);
                    }
                });

                for (int i = 0; i < actorsList.size(); i++) {
                    System.out.println("monika 1233"
                            + actorsList.get(i).getPrice());
                }
            }
        });

    }

}

edited Aug 11, 2014 at 12:40

answered Aug 11, 2014 at 9:22

KOTIOS

11.1k3 gold badges42 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Sun Over a year ago

i want to implement both the functionalities, a button to show list High to Low and another to show list Low to High

Sun Over a year ago

but I want to implement sort functionality on click of buttons, see my code above

KOTIOS Over a year ago

yes thats what creat a method in pojo class and that tell whether u want asc or dec order sorting

KOTIOS Over a year ago

so in compare method above provide if else hence that will give u sorting data

KOTIOS Over a year ago

best to do is : always sort in asc and do Arrays.sort(data, Collections.reverseOrder());

|

dounyy · Accepted Answer · 2014-08-11 09:21:37Z

0

You can use Collections.sort, which takes a comparator in argument. In the comparator you will define what you want to compare (here, the price).

answered Aug 11, 2014 at 9:21

dounyy

66513 silver badges26 bronze badges

Comments

Vinothkumar Arputharaj · Accepted Answer · 2014-08-11 09:25:58Z

0

If you just want to sort the list by price, use custom comparator. If you want filter the list based on any search term, use Filterable interface

answered Aug 11, 2014 at 9:25

Vinothkumar Arputharaj

4,5694 gold badges31 silver badges38 bronze badges

Comments

Unihedron · Accepted Answer · 2014-08-11 11:35:52Z

0

Make class like this:

class PriceSort implements Comparator<location> {
    @Override
    public int compare(location cr1, location cr2) {

          long l1 = Integer.parseInt(cr1.getPrice());
          long l2 = Integer.parseInt(cr2.getPrice());
          return Long.compare(l1, l2);

    }
}

And call like:

Collections.sort(actorsList, new PriceSort());

edited Aug 11, 2014 at 11:35

Unihedron

11.1k13 gold badges65 silver badges72 bronze badges

answered Aug 11, 2014 at 9:22

Digvesh Patel

6,5331 gold badge23 silver badges34 bronze badges

Comments

Unihedron · Accepted Answer · 2014-08-11 11:42:33Z

0

I added code for int sorting:

Collections.sort(actorsList, new Comparator<Locations>() {
    public int compare(Locations user1, Locations user2) {
        return user1.price.compareTo(user2.price);
    }
});

And implement Comparable method in your Location model:

Locations implements Comparable<Locations>

edited Aug 11, 2014 at 11:42

Unihedron

11.1k13 gold badges65 silver badges72 bronze badges

answered Aug 11, 2014 at 9:22

Divyang Metaliya

1,9181 gold badge12 silver badges14 bronze badges

Collectives™ on Stack Overflow

Sorting ArrayList not affecting to ArrayList

5 Answers 5

7 Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

7 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related