Angularjs, how to prevent bind twice in controller

Question

I have code in homepage controller:

$scope.$on('showInfo', function(){
   console.log('ok');
});

And anywhere i call:

$rootScope.$broadCast('showInfo');

It's work well, but have a case following:

I go to other (single page, don't reload page)
Comback 'homepage', then $scope.$on will be called twice ( and if i go to other page 'N' times, $scope.$on will be called 'N' times)

I can't know reasons

:( it's very bad

Thanks for help me.

What are you trying to achieve? Please give more context. $broadcast might not be the right solution. — apairet
– apairet, Commented Aug 11, 2014 at 6:17
have you looked at Route Provider ?? You can inject controller as per your need. — streak
– streak, Commented Aug 11, 2014 at 6:18

Sabacc · Accepted Answer · 2014-08-11 06:54:04Z

1

If you're not using angularjs routes as your routing mechanism, you'll end up having an additional instance of a controller after each "navigation". Old controllers won't get destroyed, so your event subscriptions stay active and process the events.

AngularJS routing prevents this by correctly "destroying" controllers, which does not remove the controllers but "deactivates" it by removing it from the $digest cycle.

It seems you're not using routing correctly or need to manage scope lifecycle by yourself (which I would'nt recommend). Second means you'll have to call $destroy() on your scope when you want it to become "deactivated".

answered Aug 11, 2014 at 6:54

Sabacc

7896 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ali Cuche Over a year ago

- call $destroy() on your scope when you want it to become "deactivated". - "deactivates" it by removing it from the $digest cycle. Can you for me a example ? Thanks very much :)

Sabacc Over a year ago

I would need to se some of your code to know why you're having multiple instances of the same controller.

Collectives™ on Stack Overflow

Angularjs, how to prevent bind twice in controller

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related