Filling an array of pointers in a function

Question

My program should fill up and show an array. It should also calculate average value in the array.

The program stops at this line:

cin >> *f1[j];

I think it's the problem line, but I could have made mistakes elsewhere.

#include <iostream>

using namespace std; 

// prototypes
void add(int*f[],int h);      
void show(int*f[],int h);
int average(int*f[],int h);

int main()
{
    // getting size of a array
    cout << "How many numbers would you insert? : ";
    int i = 0;
    cin >> i;
    cout << endl;

    // the dinamic array
    int * arr = new int[i]; 

    // call functions
    add(&arr, i);
    show(&arr, i);
    average(&arr, i);

    // deleting the dinamic array
    delete[] arr;
    system("pause");
    return 0;
}

// declaring of the functions

// this function should fill up the array
void add(int* f1[], int h)
{
    for(int j = 0 ; j < h ; j++)
    {
        cout << "Insert " << j+1 << ". value : ";
        cin >> *f1[j]; //this should be the problem
        cout << endl;
    }

}

// this function should show the array
void show(int *f2[], int h)
{
    for(int j = 0 ; j < h ; j++)
    {
        cout << *f2[j] << ", ";
    }
}

// this function should should show average value of the array
int average(int *f3[], int h)
{
    int n = 0;
    for(int j = 0 ; j < h ; j++)
    {
        n += *f3[j];
    }
    n /= h;
    return n;
}

progrenhard · Accepted Answer · 2014-08-08 18:58:34Z

1

You aren't referencing your arrays correctly. p* points to index p[0]

cout << *f2[j] << ", ";

should be

cout << f2[j] << ", ";

It compiles and runs with the edits I made.

http://ideone.com/DsxOOP

Also, You aren't taking any inputs.

edited Aug 8, 2014 at 18:58

answered Aug 8, 2014 at 18:44

progrenhard

2,3732 gold badges15 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Julian · Accepted Answer · 2014-08-08 19:08:17Z

0

You'll need to:

use int* fX in your function signatures
drop the & referencing from your function calls (you already have a memory address stored in arr and there's no such thing as a memory address for another memory address)
not use * dereferencing within your functions (you're already dereferencing the array with [] indexing)

http://pastebin.com/xY7A6JvE compiles and runs.

answered Aug 8, 2014 at 19:08

Julian

7571 gold badge6 silver badges21 bronze badges

Collectives™ on Stack Overflow

Filling an array of pointers in a function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related