javascript change url and text on click

Question

I'm using the below code and it seems to only be half working.

I am trying to make it so when a user clicks on the url the text for the a href tag changes.

For example, a user goes on my site. When they click the url 'Love station' it replaces the text and url to 'Dump Station' if the user then clicks 'Dump station' again it changes it back to 'Love Station'

At the moment it changes the text to dump station, but once i click it again, nothing happens.

Any ideas?

<script type="text/javascript">
function lovestation() {

$.get("../lovestation.php?id=<?echo $sta->ID;?>");
document.getElementById('love').innerHTML="Dump <? echo "$sta->Title";?>"
document.getElementById('love').id="dump"
document.getElementById('love').onclick="dumpstation();"

return false;

}



function dumpstation() {
$.get("../dumpstation.php?id=<?echo $sta->ID;?>");
document.getElementById('dump').innerHTML="Love <? echo "$sta->Title";?>"
document.getElementById('dump').id="dump"
document.getElementById('dump').onclick="dumpstation();"
return false;
}


</script>

What could document.getElementById('dump').id="dump" possibly do? — techfoobar
– techfoobar, Commented Aug 2, 2014 at 14:40
it will not run because document.getElementById('love').innerHTML="Dump <? echo "$sta->Title";?>" should be document.getElementById('love').innerHTML="Dump <? echo '$sta->Title';?>" did you just noticed i have change one double coutation mark to single coutation mark — anni
– anni, Commented Aug 2, 2014 at 14:52
@anni. That will litterly echo the string "$sta->Title" not the value that is assigned to the variable. — putvande
– putvande, Commented Aug 2, 2014 at 14:54

putvande · Accepted Answer · 2014-08-02 14:51:34Z

2

You are referencing the onclick to a string: document.getElementById('dump').onclick="dumpstation();".
It should be :

document.getElementById('dump').onclick = dumpstation;

answered Aug 2, 2014 at 14:51

putvande

15.3k3 gold badges37 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

javascript change url and text on click

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related