Python: try-catch with multiple excepts with almost identical code

Question

I have somthing similar in my code below, where I have multiple except statements and all of them have to execute the someCleanUpCode() function. I was wondering if there is a shorter way to do it. Like a block that is only being executed when there was an exception. I can't use the finally block because that's also being executed when the try doesn't raise an error. And I only need to execute the someCleanUpCode() when there was an error. I first want to print the error and after that, run the someCleanUpCode()

try:
  dangerousCode()

except CalledProcessError:
  print "There was an error without a message"
  someCleanUpCode()
except Exception as e:
  print "There was an error: " +repr(e)
  someCleanUpCode()

I'm not aware of any other way to do this. I think the current code is fine - it makes it clear that someCleanUpCode is called in every error case. — jonrsharpe
– jonrsharpe, Commented Jul 30, 2014 at 14:26
Assuming the dangerous code is always a function, and you have lots of them, you might want to wrap it with an @foo wrapper that adds the try/except routine whenever the function is called. — chiffa
– chiffa, Commented Jul 30, 2014 at 15:09

bruno desthuilliers · Accepted Answer · 2014-07-30 14:31:08Z

1

Assuming CalledProcessorError subclasses Exception (which should be the case):

try:
   dangerous_code()
except Exception as e:
   print "There was an error %s" % ("without an error" if isinstance(e, CalledProcessError) else repr(e))
   some_cleanup_code()

or if you have more to do:

try:
   dangerous_code()
except Exception as e:
       try:
   dangerous_code()
except Exception as e:
   if isinstance(e, CalledProcessError):
       print "There was an error without a message"
   else:
       print "There was an error: " +repr(e)
   some_cleanup_code()

answered Jul 30, 2014 at 14:31

bruno desthuilliers

78.3k6 gold badges102 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bosiwow Over a year ago

I see, you can do it like this. But this can become very messy when I've got more than two excepts :). But thanks for this code.

bruno desthuilliers Over a year ago

Yes if you have half a dozen except clauses each with it's own specific stuff, your current structure is possibly cleaner... but it's not DRY.

user2682863 · Accepted Answer · 2014-07-30 14:29:10Z

1

are you looking for something like this?

try:
    1/0
except (ValueError, ZeroDivisionError) as e:
    print e
    # add some cleanup code here


>>>integer division or modulo by zero

This catches multiple exceptions

answered Jul 30, 2014 at 14:29

user2682863

3,2281 gold badge31 silver badges39 bronze badges

1 Comment

Bosiwow Over a year ago

But the problem is that only a part of the code is shared. Not the entire code is the same.

Collectives™ on Stack Overflow

Python: try-catch with multiple excepts with almost identical code

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related