AngularJS initializing $scope of directive/controller

Question

I put the init() function outside of the return of my directive :

app.directive('myDirective', function()
{
    return {
        restrict: 'C',
        controller: function($scope)
        {
            init($scope);
        }
    }

    function init($scope) 
    {
        $scope.params = [];

        // Other initializations
    }
});

Is this bad practice or a bad idea? I just don't like to have the init() inside the controller since I feel that things inside the controller are meant to be reused and run continuously.

One of my reasoning for putting it at the end is that initialization happens once, and I want to place it at the very bottom of the code, where it doesn't bother me, and doesn't steal space from my other code that I spend more time on.

What do you think/suggest?

Its a matter of preference. Breaking up a bigger function so that it calls sub-functions through divide and conquer is a good strategy. Personally, I would prefer to put the init function inside of the controller function (limit the scope and move it so that it is closer to where it is used) — Michael Kang
– Michael Kang, Commented Jul 23, 2014 at 7:00
@pixelbits, okay that makes sense. For me there are two reasons why I want it out: 1. I don't like indentation. 2. Initialization happens once, and it is the simple thing. I want to put it at the very bottom of the page as to not worry about it — Kousha
– Kousha, Commented Jul 23, 2014 at 7:02

link · Accepted Answer · 2014-07-23 07:15:18Z

4

I've seen patterns similar to yours many times, don't worry too much about it. The only thing I would change is moving the initialization to the link function; the controller in directives is used to expose an API to other directive (used through require), so I wouldn't mix it with other stuff. I try to keep the API/communication part clean and initialize/bind stuff in the link function.

answered Jul 23, 2014 at 7:15

link

1,6861 gold badge13 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kousha Over a year ago

Thanks, and haha sorry but your name is link, and you prefer the link :p. I voted your answer for the explanation!

Collectives™ on Stack Overflow

AngularJS initializing $scope of directive/controller

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related