PHP logical operators within IF statement

Question

I have the following code:

PHP

if($brand == 'ABC' && $main == ''){
    include '../_inc/report.php';
}else
if($brand == 'ABC' && $main == 'TRUE'){
    include '../_inc/analysis.php';
}else
if($brand == 'XYZ' || $brand == '123' || $brand == '1A9' && $main == ''){
    include '../_inc/report.php';
}else
if($brand == 'XYZ' || $brand == '123' || $brand == '1A9' && $main == 'TRUE'){
    include '../_inc/analysis.php';
}

Information is passed to the PHP page within the URL, such as:

?br=ABC&cr=MAY2014&pd=NOV2013&mn=TRUE
?br=XYZ&cr=MAY2014&pd=NOV2013&mn=TRUE

And handled as follows:

$brand = $_GET['br'];
$main = $_GET['mn'];

What is happening is that if $brand = ABC and $main = TRUE then the analysis.php is loaded successfully (which is correct).

However, if $brand = XYZ and $main = TRUE then report.php is loaded, which is not the behaviour I expect or need.

Is this connected with the way the operators work or is my code incorrect. Any help and feedback welcomed.

Gergo Erdosi · Accepted Answer · 2014-07-18 09:59:12Z

1

&& has higher precedence than ||. Your current code does this:

if($brand == 'XYZ' || $brand == '123' || ($brand == '1A9' && $main == '')){

This evaluates to true, because $brand == 'XYZ' is true. Use parentheses to correct the statement:

if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == ''){

See Operator Precedence for more details.

answered Jul 18, 2014 at 9:59

Gergo Erdosi

42.3k21 gold badges122 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rack_nilesh · Accepted Answer · 2014-07-18 09:51:25Z

1

You should write conditions with proper brckets.

Try below code

if($brand == 'ABC' && $main == ''){
    include '../_inc/report.php';
}else
if($brand == 'ABC' && $main == 'TRUE'){
    include '../_inc/analysis.php';
}else
if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == ''){
    include '../_inc/report.php';
}else
if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == 'TRUE'){
    include '../_inc/analysis.php';
}

answered Jul 18, 2014 at 9:51

rack_nilesh

5535 silver badges18 bronze badges

1 Comment

Homer_J Over a year ago

ARGH!!!!! Thank you for that, much appreciated. Cannot believe I missed it. DOH!!!

user3702775 · Accepted Answer · 2014-07-18 09:51:39Z

1

Try this

if($brand == 'ABC' && $main == ''){
    include '../_inc/report.php';
}else
if($brand == 'ABC' && $main == 'TRUE'){
    include '../_inc/analysis.php';
}else
if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == ''){
    include '../_inc/report.php';
}else
if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == 'TRUE'){
    include '../_inc/analysis.php';
}

answered Jul 18, 2014 at 9:51

user3702775

2711 silver badge8 bronze badges

Comments

Sadikhasan · Accepted Answer · 2014-07-18 10:05:54Z

0

You have problem with operator precedence. Try this

if($brand == 'ABC' && $main == ''){
    include '../_inc/report.php';
}else
if($brand == 'ABC' && $main == 'TRUE'){
    include '../_inc/analysis.php';
}else
if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == ''){
    include '../_inc/report.php';
}else
if(($brand == 'XYZ' || $brand == '123' || $brand == '1A9') && $main == 'TRUE'){
    include '../_inc/analysis.php';
}

answered Jul 18, 2014 at 10:05

Sadikhasan

18.6k23 gold badges84 silver badges126 bronze badges

Comments

iautomation · Accepted Answer · 2014-07-18 10:11:23Z

0

This can be written in a much shorter way:

$include = false;
if($brand=='ABC'){
    if(empty($main))$include = 'report';
    else if($main)$include = 'analysis';
} else if(in_array($brand, array('XYZ', '123', '1A9'))){
    if(empty($main))$include = 'report';
    else if($main)$include = 'analysis';
}
if($include)include '../_inc/'.$include.'.php';

answered Jul 18, 2014 at 10:11

iautomation

1,10411 silver badges18 bronze badges

Collectives™ on Stack Overflow

PHP logical operators within IF statement

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related