Angular controller function placement

Question

So I have a clearNotification function I want to trigger when I click the '#upload' button. I set an ng-click on that button to trigger notify().

What I'm wondering is if it's a violation of separation of concerns to put that clearNotification function within notify(). Is it better to add that as another ng-click on '#upload'? Or is this where directives come in?

Would love any input on this.

So far, this is what my code looks like:

HTML:

<button id="upload" ng-click="notify()">Upload</button>

Controller:

$scope.clearNotification = function() {
  $scope.notification = '';
};

$scope.notify = function() {
  $scope.clearNotification();
  ...
};

Do you really need to define clearNotification in the scope? Do you use it somewhere like in ngClick? You maybe only need normal function definition function clearNotification() {...}. — dfsq
– dfsq, Commented Jul 17, 2014 at 20:57
yea that is what I will be doing if its better to keep it the way it is now. — Brice Lin
– Brice Lin, Commented Jul 17, 2014 at 20:59

Amir Popovich · Accepted Answer · 2014-07-17 21:01:08Z

1

There's nothing wrong with calling controller functions from other controller functions.

If the clearNotification function has some business logic, then add it to a service(and inject that service into your controller). Thats the correct way to seperate components.

Should this be a directive? Only if this is a re-usable component that can live alone.

answered Jul 17, 2014 at 21:01

Amir Popovich

30.1k9 gold badges58 silver badges102 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Angular controller function placement

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related