Replace goto into while loop?

Question

I am using goto if there is any error and it would start again at the top.

I also can't use goto in the function to jump outside of the function.

I know goto is bad but how would while loop would fit into my code?

For example:

$ch = curl_init();

retry:

$result = curlPost($ch, "home.php", http_build_query($arg));

if (strpos($postResult, "Welcome") !== false) {
    sleep(10);
    goto retry;
}

$sql = "SELECT * FROM data";
$q = mysql_query($sql) or die(mysql_error());

while($row =  mysql_fetch_assoc($q)) {
    $name['something'] = $row['name'];
    submitData($ch,$name);
}


function submitData($ch,$name) {

    $result2 = curlPost($ch, "submit.php", http_build_query($name));

    if (strpos($postResult, "Website close") !== false) {
        sleep(10);
        goto retry; //goto wouldnt work.
    }

   // do something here
}

It will fit better than goto.

Phantom
– Phantom

2014-07-07 14:04:47 +00:00
Commented Jul 7, 2014 at 14:04 — Phantom
– Phantom, Commented Jul 7, 2014 at 14:04
@Phantom Post answer using while loop with my example.

user1246800
– user1246800

2014-07-07 14:06:28 +00:00
Commented Jul 7, 2014 at 14:06 — user1246800
– user1246800, Commented Jul 7, 2014 at 14:06

Niet the Dark Absol · Accepted Answer · 2014-07-07 14:07:54Z

1

Basically, you would have something like this:

$success = false;
while(!$success) {
    // do stuff here
    // psuedocode follows:
    if failure {
        continue; // skip remainder of `while` and retry
    }
    if complete {
        $success = true; // loop will end
        // or "break;" to exit loop immediately
    }
}

Just be aware that if your "if failure" is itself inside a loop, you will need continue 2;. Or if you're in a nested loop, continue 3; and so on.

answered Jul 7, 2014 at 14:07

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user1246800 Over a year ago

Thanks, that was helpful. I think I have managed to replace my example using while loop.. could you check if this is correct? pastebin.com/U5Bpkt7A

Niet the Dark Absol Over a year ago

Almost. Just false typo'd as flase and you don't need $tryAgain. Also retry with submitData logic was backwards. Try this

Collectives™ on Stack Overflow

Replace goto into while loop?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related