Javascript fixing my flatten(array) function

Question

I can not figure out why my code does not flatten out the nested arrays as indicated. I'd greatly appreciate some help here. I used a recursion to get to the actual value of the nested array. I tried to debug my code, and it seems to replace my results array every time the recursion takes place.

//Helper methods

function toType(obj){
    return ({}).toString.call(obj).match(/\s([a-zA-Z]+)/)[1].toLowerCase()
}

function each(collection, callback){
    if (Array.isArray(collection)){
        for (var i = 0; i < collection.length; i++){
            callback(collection[i], i, collection)
        }
    } else {
        for (var i in collection){
            callback(collection[i], i, collection)
        }
    }
}

//Flatten function

function flatten(array, isShallow=false, callback){
    var results = [];
    each(array, function(item){
        if (!!isShallow && toType(item) === 'array'){
            each (item, function(value){
                results.push(value);
            })
        } else if (toType(item) !== 'array'){
            results.push(item);
        } else {
            return flatten(item)
        }
    })
    return results;
}

flatten([1, [2], [3, [[4]]]]);

// ---> [1]

Golf answer: function flatten(a){return a.reduce(function(a,b){return a.concat(b.map?flatten(b):b)},[])} — 000
– 000, Commented Jun 17, 2014 at 21:20
In what environment you are running this code? It’s required to ECMA6 support as you are using developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/… — Krzysztof Safjanowski
– Krzysztof Safjanowski, Commented Jun 17, 2014 at 21:23

matt · Accepted Answer · 2014-06-17 21:19:17Z

2

Your problem appears to be with this line:

return flatten(item)

Returning here is a problem because the loop will end and the current entries in results will be ignored, as well as the remaining items. The line should be changed to instead append the results of

flatten(item)

to results array via push.

I recommend using a library for this sort of thing. http://underscorejs.org/#flatten is a great one!

answered Jun 17, 2014 at 21:19

matt

1135 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

richguan Over a year ago

Thanks for your reply. I would use a library for this sort of thing, but since I am pretty new at Javascript, my friend recommended me to write my own functions that would work the same as if I were using Underscore or Lo-Dash. removing 'return' provides me with the same output.

matt Over a year ago

did you try replacing the return flatten(item) with something like this: each(flatten(item), function(x) {results.push(x);});

richguan Over a year ago

I just tried, and that does provide me with the answer I am looking for. Is there a reference you can suggest so that I could figure out why I am able to reference the 'var results' as opposed to my original code? Is it mainly a problem regarding my understanding of variable scope? Edit: Ah, I see how this change in code works. Thanks again!

matt Over a year ago

JavaScript: The Good Parts is a very good book and is where I learned about JavaScript's scoping. It seems right up your alley (given your earlier comments about learning JavaScript). I recommend opening a browser console or node.js command line interface and trying things as you read through the book. Here's a link to a page that seems to explain each of the concepts you'll want to understand: ryanmorr.com/understanding-scope-and-context-in-javascript

Gabs00 · Accepted Answer · 2014-06-18 00:57:23Z

1

Please see the refactored code below.

The major change is that instead of creating new copies of results, we are passing it to subsequent calls to flatten as a reference.

Please see the added comments

//Helper methods

function toType(obj){
    return ({}).toString.call(obj).match(/\s([a-zA-Z]+)/)[1].toLowerCase()
}

function each(collection, callback){
    if (Array.isArray(collection)){
        for (var i = 0; i < collection.length; i++){
            callback(collection[i], i, collection)
        }
    } else if(typeof collection === 'object'){ 
        //type number was failing here
        for (var i in collection){
            callback(collection[i], i, collection)
        }
    }
    else {
        //default for primitive types
        callback(collection, 0, collection);
    }
}
//Flatten function

//Removed isShallow, how do we know if its shallow or not?
//Added results as arg, so we only manipulate the reference to results
//And to not create multiple scopes of var results;
function flatten(array, results, callback){
    results = results || [];
    each(array, function(item){

        //removed 3rd if clause not needed. 
        //Only need to know if item is an object or array
        if (toType(item) === 'array' || toType(item) === 'object'){
            each (item, function(value){
                flatten(value,results);
            })
        } else {
            results.push(item);
        }
    })

    return results;
}


var array1 = [1,[2,[3,4]]];
var array2 = [5,[6,[7,[8, {a:9,b:[10,11,12]}]]]];
var obj = {a:array1, b:array2};


console.log(flatten(array1)); // [ 1, 2, 3, 4 ]
console.log(flatten(array2)); // [ 5, 6, 7, 8, 9, 10, 11, 12 ]
console.log(flatten(obj)); // [ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12 ]

answered Jun 18, 2014 at 0:57

Gabs00

1,8771 gold badge13 silver badges12 bronze badges

3 Comments

richguan Over a year ago

Thank you for your answer. This was very helpful for me. Looks like I need to learn to get a better understanding of variable scope.

Gabs00 Over a year ago

@svntwosix, don't forget to pick an answer if any of them resolved your issue. Also, is there any reason you added a callback to flatten()?

richguan Over a year ago

@Gabbs, Thanks for the tip. What I wanted to replicate was Lo-Dash's use of the function flatten. (lodash.com/docs#flatten). Callback will be used to flatten properties in an object.

a8m · Accepted Answer · 2014-08-21 05:04:17Z

0

You can do something like that:

function flatten(array, i) {
  i = i || 0;

  if(i >= array.length)
    return array;

  if(Array.isArray(array[i])) {
    return flatten(array.slice(0,i)
      .concat(array[i], array.slice(i+1)), i);
  }

  return flatten(array, i+1);
}

Example:

var weirdArray = [[],1,2,3,[4,5,6,[7,8,9,[10,11,[12,[[[[[13],[[[[14]]]]]]]]]]]]]
flatten(weirdArray);
//returns ==> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14]

answered Aug 21, 2014 at 5:04

a8m

9,4844 gold badges39 silver badges41 bronze badges

Comments

Pratik Barasia · Accepted Answer · 2017-06-20 22:36:49Z

0

The best way to flatten you array in javascript is to use splice function of Array. Please follow the following code. It works for nesting as well.

 function flattenArray(arr){

  for(var i=0;i<arr.length;i++){

    if(arr[i] instanceof Array){

      Array.prototype.splice.apply(arr,[i,1].concat(arr[i]))
    }

  }

  return arr;
}

answered Jun 20, 2017 at 22:36

Pratik Barasia

5611 gold badge3 silver badges14 bronze badges

Comments

isaac9A · Accepted Answer · 2014-06-17 21:26:41Z

-1

Use underscore.js's flatten function (http://underscorejs.org/#flatten). Underscore.js is a 3rd party library with 80 some-odd functions to make your life as a javascript programmer easier. Don't reinvent the wheel.

var _ = require('underscore');
_.flatten([1, [2], [3, [[4]]]]);
=> [1, 2, 3, 4];

edited Jun 17, 2014 at 21:26

answered Jun 17, 2014 at 21:20

isaac9A

9134 gold badges12 silver badges31 bronze badges

3 Comments

Bergi Over a year ago

Nonetheless, the question was to "figure out why [the] code does [not work]"

isaac9A Over a year ago

I am simply suggesting [that] the OP use a 3rd party library to do something in 2 lines. Not only does using underscore [in this case] make the code easier to read, it also would have saved the OP from working out all the nasty recursion that he[/she/it] is clearly having problems with.

richguan Over a year ago

Thanks for your reply. I would use a library for this sort of thing, but since I am pretty new at Javascript, my friend recommended me to write my own functions that would work the same as if I were using Underscore or Lo-Dash. Recursions are not my strong suit.

Collectives™ on Stack Overflow

Javascript fixing my flatten(array) function

5 Answers 5

4 Comments

3 Comments

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

4 Comments

3 Comments

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related