using php to provide a variable in an onclick event

Question

I am trying to pass a variable through the onclick function into javascript.

So I am trying to pass

onclick = "purchase_song(<?php echo $row['filename']; ?> , <?php echo $row['price'] ?> )"

note the function works fine if I pass it a non php variable

onclick = "purchase_song( 'filename'  , 1)"

And I use a similar technique to pass variables through hyperlinks and the GET function. Is it not possible to use PHP inside a javascript onlick? If so, what am I doing wrong.

Thanks,

PHP runs on the server. The HTML in the browser should look the same. Just view the page source in the browser and the difference between the static (non php) and the dynamic (php) version should be obvious. — GolezTrol
– GolezTrol, Commented May 17, 2014 at 22:39
Have a look at the generated code. It should be clear from that what the problem is. Also, Learn how to debug JavaScript. — Felix Kling
– Felix Kling, Commented May 17, 2014 at 22:50
Thanks, I had actually tried that but thought I had to put it in as &lsque; etc — Krone
– Krone, Commented May 17, 2014 at 22:53

souslov · Accepted Answer · 2014-05-17 22:38:30Z

3

If the values are valid strings then you are doing everything right except one thing : to pass php input as a string argument to the javascript function you should wrap it in single quotes ':

onclick = "purchase_song('<?php echo $row['filename']; ?>' , '<?php echo $row['price'] ?>')"

answered May 17, 2014 at 22:38

souslov

44.7k11 gold badges92 silver badges113 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Krone Over a year ago

Thanks, I had actually tried that but thought I had to put it in as &lsque; etc

Community · Accepted Answer · 2023-11-17 20:16:04Z

0

The values should need to be quoted.

onclick="<?php printf("purchase_song('%s', '%s')", $row['filename'], $row['price'] ?>"

This example uses printf as its easer to see what the output from the format string.

edited Nov 17, 2023 at 20:16

CommunityBot

11 silver badge

answered May 17, 2014 at 22:50

max

103k15 gold badges113 silver badges177 bronze badges

Collectives™ on Stack Overflow

using php to provide a variable in an onclick event

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related