Java ArrayList.add overwriting values

Question

have this class

 public class Taxonomia {

    private static ArrayList<String> hijas;
    private static String padre;

    public Taxonomia (String p, ArrayList<String> h){
        hijas = h;
        padre = p;
        }

}

used in another class like this:

public class TablaSimbolica {

private static ArrayList<Taxonomia> taxonomias = new ArrayList<Taxonomia>();

public static void addTaxonomica(){

    System.out.println("enter value: ");
    String padre = Entrada.read(); //reads input and returns String
    System.out.println("entre value comma separated: ");
    String reemplazado = Entrada.read();
    ArrayList<String> items = new ArrayList<String>(Arrays.asList(reemplazado.split("\\s*,\\s*")));
    Taxonomia t = new Taxonomia (padre, items);
    taxonomias.add(t);  

}

when called from the main simple as this (print its just a for...)

TablaSimbolica.addTaxonomica();
TablaSimbolica.addTaxonomica();
TablaSimbolica.printTax();

all the objects are the same, and i cant figure out where it is im missing the creation of a new object or something like that. thanks in advance!

only one value of static variable can exists at a time. leave the unnecessary static out and you are good to go. — madteapot
– madteapot, Commented Apr 29, 2014 at 23:29

rgettman · Accepted Answer · 2014-04-29 23:25:36Z

1

Your class variables in the Taxonomia class are static, meaning only one of each for the entire class, no matter how many instances.

Make it one per instance by removing static. Change

private static ArrayList<String> hijas;
private static String padre;

to

private ArrayList<String> hijas;
private String padre;

answered Apr 29, 2014 at 23:25

rgettman

179k30 gold badges282 silver badges365 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Java ArrayList.add overwriting values

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related