foreach loop in a php function

Question

I'm trying to make a foreach loop, that runs through the Db table, and echoes it out in a function, but when i try to do this, it takes the rows i have in the object, and echoes the object out as many times as i have rows, and doesn't proceed to the next object in the table. help is appreciated. Here is my code:

function hotels_from_db() {
include 'DbConnection.php';
$sql = "select * from hotels";

$result = $mysqli->query($sql);

$row = $result->fetch_object();

    foreach ($row as $value) {   
    $foundhotel = "<h1>" . $row->hotel_name . "</h1></br>";
    $foundhotel.= $row->hotel_adress . "</br>";
    $foundhotel.= $row->hotel_postal_code . "</br>";
    $foundhotel.= $row->description;
    echo "$foundhotel";
    }  
  }

tried doing this aswell, but this only displays the Last hotel in the table.

function hotels_from_db() {
include 'DbConnection.php';
$sql = "select * from hotels";

$result = $mysqli->query($sql);

$row = $result->fetch_object();
while($row = $result->fetch_object()){           
    $foundhotel = "<h1>" . $row->hotel_name . "</h1></br>";
    $foundhotel.= $row->hotel_adress . "</br>";
    $foundhotel.= $row->hotel_postal_code . "</br>";
    $foundhotel.= $row->description;
    echo "$foundhotel";
    }

}

Fracsi · Accepted Answer · 2014-04-15 13:19:03Z

2

->fetch_object retrieves only one row

Try this:

function hotels_from_db() {
include 'DbConnection.php';
$sql = "select * from hotels";
$result = $mysqli->query($sql);

while($row = $result->fetch_object()) {   
    $foundhotel = "<h1>" . $row->hotel_name . "</h1></br>";
    $foundhotel.= $row->hotel_adress . "</br>";
    $foundhotel.= $row->hotel_postal_code . "</br>";
    $foundhotel.= $row->description;
    echo "$foundhotel";
}

}

answered Apr 15, 2014 at 13:19

Fracsi

2,32416 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Stender Over a year ago

hmm, then it only displays the last object in the table, so all the other hotels are not being echoed.

Amadu Bah · Accepted Answer · 2014-04-17 15:56:28Z

0

fetch_object needs to be called for each row fetch. Try the following:

function hotels_from_db() {
    include 'DbConnection.php';
    $sql = "select * from hotels";

    if ($result = $mysqli->query($sql)) {

        /* fetch object array */
        while ($obj = $result->fetch_object()) {
            $foundhotel = "<h1>" . $obj->hotel_name . "</h1></br>";
            $foundhotel.= $obj->hotel_adress . "</br>";
            $foundhotel.= $obj->hotel_postal_code . "</br>";
            $foundhotel.= $obj->description;
            echo "$foundhotel";        
        }

        /* free result set */
        $result->close();
    }
}

edited Apr 17, 2014 at 15:56

answered Apr 15, 2014 at 13:24

Amadu Bah

2,99530 silver badges27 bronze badges

3 Comments

Stender Over a year ago

this return the error - mysqli::query() [mysqli.query]: Empty query, can't explain why though

Stender Over a year ago

still returns an error - mysqli_result::fetch_object() expects parameter 1 to be string

Amadu Bah Over a year ago

Should be fixed. Sorry. Reference: us3.php.net/manual/en/mysqli-result.fetch-object.php

Pwner · Accepted Answer · 2014-04-15 13:18:11Z

0

It should be:

function hotels_from_db() {
    include 'DbConnection.php';
    $sql = "select * from hotels";

    $result = $mysqli->query($sql);

    $row = $result->fetch_all();

    foreach ($row as $value) {   
        $foundhotel = "<h1>" . $value->hotel_name . "</h1></br>";
        $foundhotel.= $value->hotel_adress . "</br>";
        $foundhotel.= $value->hotel_postal_code . "</br>";
        $foundhotel.= $value->description;
        echo "$foundhotel";
    }  
}

answered Apr 15, 2014 at 13:18

Pwner

7715 silver badges16 bronze badges

1 Comment

Stender Over a year ago

thanks for the quick comment, but i have tried this, and then it just makes a whole lof of white space, and nothing from the db comes on the screen.

Abdullah Aden · Accepted Answer · 2014-04-15 13:22:29Z

0

$row = $result->fetch_all(MYSQLI_ASSOC); // MAKE ARRAY ASSOCIATIVE ARRAY

foreach ($row as $value) {   
    $foundhotel = "<h1>" . $value->hotel_name . "</h1></br>";
    $foundhotel.= $value->hotel_adress . "</br>";
    $foundhotel.= $value->hotel_postal_code . "</br>";
    $foundhotel.= $value->description;
    echo "$foundhotel";
}

}

answered Apr 15, 2014 at 13:22

Abdullah Aden

9329 silver badges13 bronze badges

1 Comment

Stender Over a year ago

hmm, this returns a Fatal error: Call to a member function fetch_all() on a non-object, but i see your point, assoc should mean that is checks the next array aswell right?

Collectives™ on Stack Overflow

foreach loop in a php function

4 Answers 4

1 Comment

3 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

3 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related