How to convert linkedlist to array using `toArray()`?

Question

I do not know how to convert a linked list of doubles to array. Please help me find the error.

import java.util.*;
public class StackCalculator {


  private   LinkedList<Double> values;
  double value1 , value2 ;

  public StackCalculator()
  {
     values = new LinkedList<Double>();
  }


    void push(double x)
    {
         values.addFirst(x);
    }
    double pop()
    {
       return values.removeFirst();
    }
    double add()
    {
        value1=pop();
        value2=pop();
        return (value1 + value2);
    }

    double mult()
    {
        value1=pop();
        value2=pop();
        return (value1 * value2);
    }


    double[] v = new double[10];
    double[] getValues()
    {
        return   values.toArray(v);
    }

}

BalusC · Accepted Answer · 2010-02-21 00:05:54Z

28

The List#toArray() of a List<Double> returns Double[]. The Double[] isn't the same as double[]. As arrays are objects, not primitives, the autoboxing rules doesn't and can't apply here.

Either use Double[] instead:

Double[] array = list.toArray(new Double[list.size()]);

...or create double[] yourself using a simple for loop:

double[] array = new double[list.size()];
for (int i = 0; i < list.size(); i++) {
    array[i] = list.get(i); // Watch out for NullPointerExceptions!
}

answered Feb 21, 2010 at 0:05

BalusC

1.1m377 gold badges3.7k silver badges3.6k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

amara Over a year ago

ow, O(n^2) for loop? why not int i = 0; for (Double v : list) array[i++] = v;

sage88 Over a year ago

Yeah that second option is pretty terrible. Sparkleshy's suggestion would be much better.

Anders Dec 3, 2024 at 8:36

Using a foreach will do much better, as it will use an Iterator if possible.

user8681 · Accepted Answer · 2010-02-21 00:01:06Z

4

The problem is the type of your list, which is Double (object), while you're trying to return an array of type double (primitive type). Your code should compile if you change getValues() to return a Double[].

For your other methods, it's not a problem, because Java automatically converts Doubles to doubles and back (called autoboxing). It cannot do that for array types.

answered Feb 21, 2010 at 0:01

user8681

Comments

sepp2k · Accepted Answer · 2010-02-21 00:01:08Z

1

toArray is defined to return T[] where T is a generic argument (the one-argument version is anyway). Since primitives can't be used as generic arguments, toArray can't return double[].

answered Feb 21, 2010 at 0:01

sepp2k

372k56 gold badges687 silver badges687 bronze badges

Collectives™ on Stack Overflow

How to convert linkedlist to array using `toArray()`?

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related