JAVA - Error incompatible types: String cannot be converted to String[ ]

Question

I'm working on Java project - Playing Cards.

And, in this Card.java class, I've declared and initialized variables and array list. I've come across this error. These errors are under each getter and setter methods.

error: incompatible types: String cannot be converted to String[]
error: incompatible types: int[] cannot be converted to int

public class Card {

   // private String suit;
    //private String name;
    //private int value;

private String[] suit = {"spades","hearts","clubs","diamonds"};
private String[] name = {"Ace","Jack","Queen","King"};
private int[] value = {1,2,3,4,5,6,7,8,9,10,11,12,13};

public Card(String s, String n, int v)
{
    suit = s;
    name = n;
    value = v;
}

public String getSuit()
{
    return suit;
}

public String getName()
{
    return name;
}

public int getValue()
{
    return value;
}

public String toString()
{
    return "<"+suit+" "+name+">";
}

This is the whole class.

Hope anyone knows and can help me out, thanks! (:

If you don't understand what i'm trying to get at, let me know, try my best to explain

What is the type of suit? What are you trying to assign to it? Similarly for value. — Sotirios Delimanolis
– Sotirios Delimanolis, Commented Apr 11, 2014 at 5:02
String cannot be assigned to String array as is and same for int also — AJJ
– AJJ, Commented Apr 11, 2014 at 5:05
What do you mean what type of suit and value? Did i not state their datatypes and and what elements in its array list? — Preeyah
– Preeyah, Commented Apr 11, 2014 at 5:10

Rahul · Accepted Answer · 2014-04-11 05:06:36Z

I bet you generated the getters and setters and the constructor for the initial set of fields which are these.

// private String suit;
// private String name;
// private int value;

But after changing them to

private String[] suit = { "spades", "hearts", "clubs", "diamonds" };
private String[] name = { "Ace", "Jack", "Queen", "King" };
private int[] value = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13 };

you forgot to modify them accordingly. You need to change your getters and setters and constructors to something like this. The same goes with the toString() method.

public class Card {

    private String[] suit = { "spades", "hearts", "clubs", "diamonds" };
    private String[] name = { "Ace", "Jack", "Queen", "King" };
    private int[] value = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13 };

    public Card(String[] suit, String[] name, int[] value) {
        super();
        this.suit = suit;
        this.name = name;
        this.value = value;
    }

    public String[] getSuit() {
        return suit;
    }

    public void setSuit(String[] suit) {
        this.suit = suit;
    }

    public String[] getName() {
        return name;
    }

    public void setName(String[] name) {
        this.name = name;
    }

    public int[] getValue() {
        return value;
    }

    public void setValue(int[] value) {
        this.value = value;
    }

    @Override
    public String toString() {
        return "Card [suit=" + Arrays.toString(suit) + ", name="
            + Arrays.toString(name) + ", value=" + Arrays.toString(value)
            + "]";
    }
}

Always remember to generate fresh getters, setters, constructor, toString() methods, if you happen to change the fields in the class.

oHo · Accepted Answer · 2016-11-03 10:28:30Z

1

Your variables suit, name and value are arrays:

private String[] suit = {"spades","hearts","clubs","diamonds"};
private String[] name = {"Ace","Jack","Queen","King"};
private int[] value = {1,2,3,4,5,6,7,8,9,10,11,12,13};

In the Constructor you are passing String s , String n, int v as a single data type and assigning it to an array suit, name and value.

public Card(String s, String n, int v)
{
    suit = s;
    name = n;
    value = v;
}

Make them String[] s, String[] n , int[] v your error will be gone:

public Card(String[] s, String[] n, int[] v)
{
    suit = s;
    name = n;
    value = v;
}

In the below code you are getting an array not a single string. Make their return type String[]

public String getSuit()
{
    return suit;
}

public String getName()
{
    return name;
}

edited Nov 3, 2016 at 10:28

oHo

55.1k30 gold badges175 silver badges209 bronze badges

answered Apr 11, 2014 at 5:19

Zar E Ahmer

34.5k20 gold badges244 silver badges306 bronze badges

Comments

raj · Accepted Answer · 2014-04-11 05:04:32Z

0

Use

for(String s:suit){
System.out.println(s);
}

to get string from array of string

answered Apr 11, 2014 at 5:04

raj

2,08814 silver badges23 bronze badges

Comments

Tanu Garg · Accepted Answer · 2014-04-11 05:15:11Z

0

Use String[] instead of String and Int[] instead of int

in your all getter setter methods.

answered Apr 11, 2014 at 5:15

Tanu Garg

3,0774 gold badges24 silver badges32 bronze badges

Comments

Devavrata · Accepted Answer · 2014-04-11 05:16:43Z

0

You are returning the array in get methods and you have declared its return type String, it should be array of Strings.

 public String[] getName()
 {
     return name;
 }

You can do it for others similarly.

answered Apr 11, 2014 at 5:16

Devavrata

1,80518 silver badges30 bronze badges

Comments

Henry · Accepted Answer · 2014-04-11 05:17:16Z

0

They are incompatible because your get methods are of type String and int, and you are asking these methods to return an array.

answered Apr 11, 2014 at 5:17

Henry

112 bronze badges

Comments

AJJ · Accepted Answer · 2014-04-11 05:19:18Z

The assignment of variables suit, name and value in the Card constructor is wrong. The variables suit , name and value are of array type and you are assigning string and int type to it., which is wrong. In Java, if the size of array is fixed, it cannot be modified. You can use array list instead as,

import java.util.ArrayList;
import java.util.Arrays;

public class Card {

    private static ArrayList<String> suitArrayList = new ArrayList<String>();
    private static ArrayList<String> nameArrayList = new ArrayList<String>();
    private static ArrayList<Integer> valueArrayList = new ArrayList<Integer>();

    private static String[] suit = {"spades","hearts","clubs","diamonds"};
    private static String[] name = {"Ace","Jack","Queen","King"};
    private static Integer[] value = {1,2,3,4,5,6,7,8,9,10,11,12,13};

    public Card(String s, String n, int v)
    {
        suitArrayList.add(s);
        nameArrayList.add(n);
        valueArrayList.add(v);
    }

    public static void main(String[] args) {
        suitArrayList.addAll(Arrays.asList(suit));
        nameArrayList.addAll(Arrays.asList(name));
        valueArrayList.addAll(Arrays.asList(value));
        Card card = new Card("ADDED SUITE", "ADDED NAME", 222222);
        for (String s : suitArrayList) {
            System.out.println("suit element :: " + s);
        }
        for (String s : nameArrayList) {
            System.out.println("name element :: " + s);
        }

        for (Integer i : valueArrayList) {
            System.out.println("value element :: " + i);
        }
    }
}

Sarfaraz Shaikh · Accepted Answer · 2022-05-18 09:30:36Z

-1

This Error incompatible types: String cannot be converted to String[ ]

Answer: The above ERROR came when the JAVA Env had some interruption while accessing the java default library. There are 2 ways to figure out this issue: 1] Reinstall the JDK and reset the JAVA Env path. Still, if you having issues or ERROR then go with the given approach.

2] Declare the String class with its package name: Ex: java.lang.String[] str = “SarfarazShaikh”; So, This will work as expected.

answered May 18, 2022 at 9:30

Sarfaraz Shaikh

11 bronze badge

Collectives™ on Stack Overflow

JAVA - Error incompatible types: String cannot be converted to String[ ]

8 Answers 8

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related