Printing string from pointer to array in c

Question

Friend I am new in c, I am trying to print string using in array of pointer I am following the code from online tutorial http://www.tutorialspoint.com/.my code link is Here's a link! all things are ok no error, when I run the the code message is shown: [Warning] deprecated conversion from string constant to 'char*' [-Wwrite-strings] there is no output, is the code in online is wrong, or what is fault can any one give me some idea my code is below:

#include <stdio.h>

const int MAX = 4;

int main ()
{
   char *names[] = {
                   "Zara Ali",
                   "Hina Ali",
                   "Nuha Ali",
                   "Sara Ali",
   };
   int i = 0;

   for ( i = 0; i < MAX; i++)
   {
       printf("Value of names[%d] = %s\n", i, names[i] );
   }

   return 0;
}

If any fault of me, I copying code, I am newer in c so I am learning from online tutorial, so please don't give any negative comment, if it also duplicate, kindly closed the question.

If you want to learn C, I suggest you use a C compiler; the use of a C++ compiler to learn C++ is adequate :) — pmg
– pmg, Commented Apr 8, 2014 at 14:30
Tip: Avoid magic constants. If you use them, make sure you get an error if they are no longer appropriate. (sizeof names/sizeof *names) is the number of elements in array names. Alternatively / additionally, put the constant into the array definition too: char *names[MAX] = ... — Deduplicator
– Deduplicator, Commented Apr 8, 2014 at 14:36

haccks · Accepted Answer · 2014-04-08 14:31:02Z

1

Remove * from *names[i] in printf;

printf("Value of names[%d] = %s\n", i, names[i] );

answered Apr 8, 2014 at 14:31

haccks

107k28 gold badges181 silver badges274 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

AntonH Over a year ago

Dangit, that's what I thought but wasn't 100% sure. Should have put it down.

Zishan Over a year ago

i removed it but nothing is changed

hyde · Accepted Answer · 2014-04-08 21:06:11Z

0

[Warning] deprecated conversion from string constant to 'char*' means, you have string literal, which are read-only, but you have a pointer to it which allows modification. So compiler warns you about that. To get rid of the warning, this should declare names as array of pointers to const char, like this:

const char *names[] = { /*...clipclip... */ };

It is "just" a warning, because old code often had such pointers, and making that an error now would prevent that from compiling. Also, this issue is no problem as long as you don't try to modify the string literals. If you do, you should get a segmentation fault or equivalent at runtime on any modern OS. Also, sometimes you might want to initialize a char* variable to point to string literal, then if necessary, change it to point to a new modifiable buffer, but any such use case should be documented with comments, and warning disabled by using an explicit cast char *s = (char*)"defaultvalue";.

edited Apr 8, 2014 at 21:06

answered Apr 8, 2014 at 21:00

hyde

63.1k22 gold badges128 silver badges181 bronze badges

1 Comment

Zishan Over a year ago

thanx, hyde, for your answer, i got the correct answer

Collectives™ on Stack Overflow

Printing string from pointer to array in c

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related