Dynamically create a onClick event handler with jQuery

Question

I have following code which builds a table from array called 'data'. I would like to add javascript call into my other method called backend_getMovieData, but I dont know how to build a string from movie._id. I'm getting error "Uncaught SyntaxError: Unexpected token } " from my example code.

data.forEach(function(movie) {
    $("#shows").find('tbody')
           .append($('<tr>') 
           .append($('<td>' + movie._id + '</td>'))
           .append($('<td>' + movie.total + ' times</td>'))
           .append($('<td><button class=\'btn btn-success\' onClick=backend_getMovieData(' + movie._id + ');>Show times</button></td>'))); 
});

Are'nt you missing the quotes around backend_getMovieData(' + movie._id + ');? — phylax
– phylax, Commented Apr 6, 2014 at 10:05
If I change this line: onClick=backend_getMovieData(' + movie._id + '); into something like: onClick=alert(\'test\'); my code is working — Panu Oksala
– Panu Oksala, Commented Apr 6, 2014 at 10:06
Oh, they are just some edits on stackoverflow question. I will edit them out. — Panu Oksala
– Panu Oksala, Commented Apr 6, 2014 at 10:09

Amit Joki · Accepted Answer · 2014-04-06 10:05:50Z

2

I think, your function is expecting a string.

Do this:

data.forEach(function(movie) {
    $("#shows").find('tbody')
           .append($('<tr>') <br />
           .append($('<td>' + movie._id + '</td>'))<br />
           .append($('<td>' + movie.total + ' times</td>'))<br />
           .append($('<td><button class=\'btn btn-success\' onClick="backend_getMovieData(\'' + movie._id + '\')";>Show times</button></td>'))); 
});

You need to wrap it with quotes.

answered Apr 6, 2014 at 10:05

Amit Joki

59.4k7 gold badges80 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Panu Oksala Over a year ago

OK, now im getting into the actual problem. Now its saying Uncaught ReferenceError: Uroot is not defined. And that Uroot is movie._id variables value.

Amit Joki Over a year ago

@Mino, I think backend_getMovieData accepts a string. Try my above code.

Panu Oksala Over a year ago

Yes it actually works! Thank you. I have too many quotes in my javascript code so I was just a bit confused :).

TwHello Inc · Accepted Answer · 2014-04-06 10:17:53Z

1

JQuery can get it done with a bit more finesse:

$("#shows").on('click', 'button.btn-success', function() { backend_getMovieData(this.id) });

data.forEach(function(movie) {
    $("#shows").find('tbody')
       .append($('<tr>') <br />
       .append($('<td>' + movie._id + '</td>'))<br />
       .append($('<td>' + movie.total + ' times</td>'))<br />
       .append($('<td><button class="btn btn-success" id="' + movie._id + '">Show times</button></td>'))); 
});

answered Apr 6, 2014 at 10:17

TwHello Inc

6014 silver badges6 bronze badges

Collectives™ on Stack Overflow

Dynamically create a onClick event handler with jQuery

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related