Inserting array values into MySQL Database

Question

A little bit stuck here (and a newbie) I'm trying to insert data from arrays into database, but not sure how to extract it: `

if ($_SERVER['REQUEST_METHOD'] == 'POST') {

// Determine how many categories there are
$cnt = count($_POST['cat']);
$insertArr = array();

for ($i = 0; $i<$cnt; $i++){
$insertArr[] = "('" . ($_POST['cat'][$i]) . "', '" . ($_POST['grade'][$i]) . "')";
}

    $q = "INSERT INTO grit (feed, grade) VALUES ('$insertArr[$i]', '$insertArr[$i]')";
    $stmt = mysqli_prepare($dbc, $q);

    // For debugging purposes:
   if (!$stmt) echo mysqli_stmt_error($stmt);
    //mysqli_stmt_bind_param($stmt, 'ss', $final_[0], $final_[1]);

    // Execute the query:
    mysqli_stmt_execute($stmt);

    if (mysqli_stmt_affected_rows($stmt) >= 1) { // If it ran OK.

        // Print a message:
        echo '<h4>feedback product has been added!</h4>';

        // Clear $_POST:
        $_POST = array();


    } else { // If it did not run OK.
        trigger_error('feedback could not be added due to a system error. We apologize for any inconvenience.');
    }

}
`

The arrays seem to be fine, but nothing get passed to the database.

post your html content.

krishna
– krishna

2014-03-19 10:33:44 +00:00
Commented Mar 19, 2014 at 10:33 — krishna
– krishna, Commented Mar 19, 2014 at 10:33
use implode(',', $insertArr);

Rakesh Sharma
– Rakesh Sharma

2014-03-19 10:35:26 +00:00
Commented Mar 19, 2014 at 10:35 — Rakesh Sharma
– Rakesh Sharma, Commented Mar 19, 2014 at 10:35
Can you post the content of $q?

secelite
– secelite

2014-03-19 10:43:04 +00:00
Commented Mar 19, 2014 at 10:43 — secelite
– secelite, Commented Mar 19, 2014 at 10:43

xate · Accepted Answer · 2014-03-19 11:11:55Z

1

for ($i = 0; $i<$cnt; $i++){
     $insertArr[] = "('" . ($_POST['cat'][$i]) . "', '" . ($_POST['grade'][$i]) . "')";
}

like already mentioned, you are already ending the for loop here, while you use the loop index in the query.

Just one thing to add: You should escape your queries, otherwise, people can write weird things into your database, and maybe destroy your datas with it.

for example, use: mysql_real_escape_string

answered Mar 19, 2014 at 11:11

xate

6,3723 gold badges20 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Git Psuh · Accepted Answer · 2014-03-19 11:49:35Z

0

Your query should read :

$q = "INSERT INTO grit (feed, grade) VALUES ('" . $insertArr[$i]. "', '". $insertArr[$i] ."')";

Plus it is out of the loop and you're using the loop index...

Try that :

$mysqli = new mysqli("localhost", "CHANGE", "CHANGE", "stackoverflow");

// This is my test array, remove that
$_POST = array ('cat' => array('meowy', 'kitty'), 'grade' => array(1,2));

$cnt = count($_POST['cat']);

for ($i = 0; $i<$cnt; $i++){

    $q = "INSERT INTO grit (feed, grade) VALUES ('" . $_POST['cat'][$i] . "', '" . $_POST['grade'][$i] . "')";
    $stmt = $mysqli->prepare($q);

    // For debugging purposes:
    if (!$stmt) echo mysqli_stmt_error($stmt);

    // Execute the query:
    $stmt->execute();

    if (mysqli_stmt_affected_rows($stmt) >= 1) { // If it ran OK.

        // Print a message:
        echo '<h4>feedback product has been added!</h4>';

    } else { // If it did not run OK.
       trigger_error('feedback could not be added due to a system error. We apologize for any inconvenience.');
    }
}

ATTENTION : Keep in mind that you have to sanitize data from the superglobal POST array. Do never use data from users without making sure that data is what you actually expect ! You should improve your code on that matter.

edited Mar 19, 2014 at 11:49

answered Mar 19, 2014 at 10:41

Git Psuh

3221 gold badge3 silver badges11 bronze badges

1 Comment

AyB Over a year ago

It will work with the present way too. Maybe this can be used for more clarity.

Scott Weldon · Accepted Answer · 2016-10-21 19:08:52Z

0

if(isset($_POST['timetab'])){
    $cos=$_POST['course'];
    $dat=$_POST['date'];
    $tim=$_POST['time'];
    $c=count($cos);
    /*a for loop for each value per column . It also works as a multi-row insertion*/
    for($i=0;$i<=$c;$i++)
    {
        $sql="INSERT INTO timetable (course_module, date, time) VALUES('$cos[$i]', '$dat[$i]', '$tim[$i]')";
        $ins=mysqli_query($conlog, $sql);       
    }
    echo(!mysqli_affected_rows($conlog))?"QUERY WRONG":"QUERY SUCCESS";
}

edited Oct 21, 2016 at 19:08

Scott Weldon

10.4k6 gold badges54 silver badges69 bronze badges

answered Oct 21, 2016 at 18:36

Manzini Lionel .T

374 bronze badges

Collectives™ on Stack Overflow

Inserting array values into MySQL Database

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related