Static method in non static class and multithreading

Question

I have a non-static class which has a static method

public class ITelcoServicesFactory
{
  public static ITelco GetITransactionHandler(int pTelcoId, int pTransactionMode)
  {
        ITelco lITelcoServices = null;
        if (pTelcoId < 0)
        {               
            lITelcoServices = new DUMMY_Impl(pTransactionMode);
            mLogger.Debug("ITransactionHandler Dummy Implementation");
        }
        return lITelcoServices;
  }

}

this method return instance on the basis of parameters. i am confuse "If multiple transaction comes at the same time will there be any issue with this method" ?

i mean multiple transaction at same time will override this method ? or every transaction will get it own object on the basis of parameters ?

PS : If it does not any harm than why ?

yes i missed return statement .. however please tell my why this would not have any issue ? — shujaat siddiqui
– shujaat siddiqui, Commented Mar 18, 2014 at 8:18

Emond · Accepted Answer · 2014-03-18 08:25:38Z

2

The only danger I see are these lines:

lITelcoServices = new DUMMY_Impl(pTransactionMode);
mLogger.Debug("ITransactionHandler Dummy Implementation");

The code of the DUMMY_Impl constructor should be examined.

And obviously you are sharing mLogger.

Have a close look (and/or post it here) at its Debug method to make sure you are not running into concurrency issues there.

answered Mar 18, 2014 at 8:25

Emond

50.8k11 gold badges86 silver badges118 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

zmbq · Accepted Answer · 2014-03-18 08:25:57Z

2

I don't know how all the previous people are so sure you're not using any shared resources. You are obviously sharing the logger, and there's no telling what your DUMMY_Impl constructor does.

Most loggers are thread-safe, so it boils down to your dummy implementation constructor. If it's thread-safe, your function is thread-safe.

answered Mar 18, 2014 at 8:25

zmbq

39.1k15 gold badges109 silver badges188 bronze badges

1 Comment

CodingIntrigue Over a year ago

Maybe they missed the logger because they can't see it declared anywhere ;)

Ramesh · Accepted Answer · 2014-03-18 08:19:22Z

1

As you are not using any static variables, you will not run into multi threading issues. All the local variables created will be available only for that thread and hence you are good.

This is not the case when you are using any static variables as they share the only instance with multiple threads

answered Mar 18, 2014 at 8:19

Ramesh

13.3k4 gold badges55 silver badges90 bronze badges

2 Comments

shujaat siddiqui Over a year ago

can you please explain why it would not be any harm ?

Ramesh Over a year ago

All the local variables created will be available only for that thread and hence each thread would get its own copy

Collectives™ on Stack Overflow

Static method in non static class and multithreading

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related