Using Angular Bootstrap Modal with external controller

Question

I'm trying to create a Modal where the controller is in an external file. This aids in code organization, and I certainly don't want the controller on the window object like the example shows at the Angular Bootstrap site. I just took their example and moved the controller to another module, but I'm getting an error that the controller doesn't exist. I get the feeling I may need to use the $controller service to retrieve it, but I can't get it to work.

angular.module('plunker', ['ui.bootstrap', 'otherModule'])

.controller('ModalDemoCtrl', function ($scope, $modal, $log) {

  $scope.items = ['item1', 'item2', 'item3'];

  $scope.open = function () {

    var modalInstance = $modal.open({
      templateUrl: 'myModalContent.html',
      controller: ModalInstanceCtrl,
      resolve: {
        items: function () {
          return $scope.items;
        }
      }
    });

    modalInstance.result.then(function (selectedItem) {
      $scope.selected = selectedItem;
    }, function () {
      $log.info('Modal dismissed at: ' + new Date());
    });
  };
});

angular.module('otherModule', [])
.controller('ModalInstanceCtrl', function($scope, $modalInstance, items) {

  $scope.items = items;
  $scope.selected = {
    item: $scope.items[0]
  };

  $scope.ok = function() {
    $modalInstance.close($scope.selected.item);
  };

  $scope.cancel = function() {
    $modalInstance.dismiss('cancel');
  };
});

Plunkr here

Patrick · Accepted Answer · 2014-03-11 18:39:41Z

2

You have to put ModalInstanceCtrl as a string. You are trying to make a reference to an object that is not defined. If controller parameter is a string, angular will look it up in the registered controllers:

var modalInstance = $modal.open({
      templateUrl: 'myModalContent.html',
      //Needs to be a string
      controller: 'ModalInstanceCtrl',
      resolve: {
        items: function () {
          return $scope.items;
        }
      }
    });

answered Mar 11, 2014 at 18:39

Patrick

6,9783 gold badges25 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Spencer Over a year ago

I swear I had tried that before with no success, but updating the Plunkr with the suggestion fixes it. Thanks.

Collectives™ on Stack Overflow

Using Angular Bootstrap Modal with external controller

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related