Javascript: Setting variables in function declaration

Question

I have the following javascript code:

    function toggleHiddenOps(dir, tour = false){
        // do stuff
    }

I noticed it was breaking in Chrome and IE (seems to work in FF 27). If I change the above to:

    function toggleHiddenOps(dir, tour){
        // do stuff
    }

It resolves the problem. Is there some issue with declaring variables like this in JS? Or perhaps my problem actually lies elsewhere?

Thanks.

Why are you wanting to assign a variable in the arguments, rather than in the function body itself? — David Thomas
– David Thomas, Commented Mar 2, 2014 at 15:32
It's possible to define defaults in JavaScript as well, but you have to do it in the function body (for most browsers, but I'm unsure as to why it's preferable to it the way you outline in your question). — David Thomas
– David Thomas, Commented Mar 2, 2014 at 15:34
That syntax is coming in ECMAScript6. At the moment, very few engines support it. — T.J. Crowder
– T.J. Crowder, Commented Mar 2, 2014 at 15:39
It's a case of writing more succinct code. I often use this syntax in PHP. — Inigo
– Inigo, Commented Mar 2, 2014 at 15:40

T.J. Crowder · Accepted Answer · 2014-03-02 16:09:01Z

1

This functionality exists only in FF for now. It will be in ECMAScript6, so expect it to start showing up in other engines over time.

Chrome, IE, Opera and Safari don't support that syntax in their latest versions.

See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/default_parameters?redirectlocale=en-US&redirectslug=JavaScript%2FReference%2Fdefault_parameters

A good workaround for this is to use arg= typeof arg !== 'undefined' ? arg : defaultValue;

For example:

function multiply(a, b) {
   b = typeof b !== 'undefined' ?  b : 1;
   return a*b;
}

multiply(5); // 5

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/default_parameters

edited Mar 2, 2014 at 16:09

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

answered Mar 2, 2014 at 15:34

edi9999

20.7k15 gold badges98 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Inigo Over a year ago

Great, thanks for the info. Best answer, will accept in a minute when I am able. Seems like a shortcoming to me... as usual FF wins.

Andrew Templeton · Accepted Answer · 2014-03-02 15:35:39Z

0

This is illegal in javascript.

If you want a default exactly false:

function toggleHiddenOps(dir, tour){
   tour = tour === void(0) ? false : tour;
   // do stuff
}

If you only care if its falsey:

function toggleHiddenOps(dir, tour){
   // do stuff, tour equals undefined now if not passed 2nd param
}

answered Mar 2, 2014 at 15:35

Andrew Templeton

1,69610 silver badges13 bronze badges

Comments

defool · Accepted Answer · 2014-03-02 15:38:36Z

0

Javascript function don't support default paramter, a hack for it is:

function toggleHiddenOps(dir, tour){
    tour = typeof tour === 'undefined' ? 'default value' : tour
    console.log(dir)
    console.log(tour)
}
toggleHiddenOps('dir')

answered Mar 2, 2014 at 15:38

defool

3012 silver badges4 bronze badges

Comments

Marat Tanalin · Accepted Answer · 2014-03-02 15:57:30Z

0

You cannot specify default values in JS using PHP syntax.

To be fair, draft ECMAScript 6 specification allows to specify default argument value like in PHP, and this is even supported in Firefox 15+, but note that support of ES6 itself is mostly experimental and can theoretically be changed or removed at any point.

A future-proof/cross-browser way to check in JS if argument is not specified is following:

function toggleHiddenOps(dir, tour) {
    if ('undefined' === typeof tour) {
        tour = 'Some default value';
    }

    // do stuff
}

edited Mar 2, 2014 at 15:57

answered Mar 2, 2014 at 15:32

Marat Tanalin

14.2k1 gold badge38 silver badges53 bronze badges

8 Comments

Inigo Over a year ago

Ah, that's what I suspected. Thanks.

T.J. Crowder Over a year ago

You can't yet. It's coming in ES6.

T.J. Crowder Over a year ago

"In JS, you can check if argument is not specified this way" That doesn't check whether the argument is unspecified. It checks whether the argument's value is undefined. It may be that it's undefined because it was unspecified; alternately, it may be that it was specified, but undefined.

T.J. Crowder Over a year ago

@MaratTanalin: I don't consider it an issue. I'm just saying the text is incorrect. I'm not saying there's a problem with the code. Other than the completely unnecessary Yoda-speak, that's how I'd do it, too.

T.J. Crowder Over a year ago

@MaratTanalin: No, of course I'm not. If you really want to know whether that argument was passed, arguments.length will tell you. (arguments being a pseudo-array created for every function call containing the actual arguments it was called with.) The check you're doing just checks for undefined, not whether the argument was passed, as I said originally. For supplying a default, I would use what you've put in the code, because arguments can be expensive on some engines. It's just the text saying what the code given does is wrong.

|

Collectives™ on Stack Overflow

Javascript: Setting variables in function declaration

4 Answers 4

1 Comment

Comments

Comments

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related