Angular promise in async loop function

Question

I have an upload function which loops through the selected files and adds them on the servers file system.

Upload factory

app.factory('uploadFactory', function ($upload, $q) {

    var uploadFactory = {};

    var image = {
        Models: [],
        Images: [],
        uploadImages: function () {
            var defer = $q.defer();
            for (var i = 0; i < this.Models.length; i++) {
                var $file = this.Models[i].file;
                (function (index) {
                    $upload
                        .upload({
                            url: "/api/upload/",
                            method: "POST",
                            file: $file
                        })
                        .success(function (data, result) {
                            // Add returned file data to model
                            var imageObject = {
                                Path: data.Path,
                                Description: image.Models[index].Description,
                                Photographer: image.Models[index].Photographer
                            };
                            image.Images.push(imageObject);

                            defer.resolve(result);
                        });
                })(i);
            }
            return defer.promise;
        }
    };

    uploadFactory.image = function () {
        return image;
    };

    return uploadFactory;
});

In my controller

$scope.imageUpload = new uploadFactory.image;
$scope.create = function () {
    var uploadImages = $scope.imageUpload.uploadImages();
    uploadImages.then(function () 
        $scope.ship.Images = $scope.imageUpload.Images;
        shipFactory.create($scope.ship).success(successPostCallback).error(errorCallback);
    });
};

My problem is that the promise only holds the promise for the first upload through the looping. I have read something about $q.all() but I'm not sure how to implement it to work.

How can I make it to hold through the whole loop? Thanks!

Solution

var image = {
    Models: [],
    Images: [],
    uploadImages: function () {
        for (var i = 0; i < this.Models.length; i++) {
            var $file = this.Models[i].file;
            var defer = $q.defer();

            (function (index) {
                var promise = $upload
                    .upload({
                        url: "/api/upload/",
                        method: "POST",
                        file: $file
                    })
                    .success(function (data, result) {
                        // Add returned file data to model
                        var imageObject = {
                            Path: data.Path,
                            Description: image.Models[index].Description,
                            Photographer: image.Models[index].Photographer
                        };
                        image.Images.push(imageObject);

                        defer.resolve(result);
                    });
                promises.push(promise);
            })(i);
        }
        return $q.all(promises);
    }
};

jlb · Accepted Answer · 2014-02-20 14:02:09Z

4

You're right $q.all() is the way to go here (totally untested -- but i think this is at least the right direction..):

app.factory('uploadFactory', function ($upload, $q) {

    var uploadFactory = {};

    var image = {
        Models: [],
        Images: [],
        uploadImages: function () {

            var promises = [];

            for (var i = 0; i < this.Models.length; i++) {

                var $file = this.Models[i].file;
                var response = $upload
                    .upload({
                        url: "/api/upload/",
                        method: "POST",
                        file: $file
                    })
                    .success(function (data, result) {
                        // Add returned file data to model
                        var imageObject = {
                            Path: data.Path,
                            Description: $file.Description,
                            Photographer: $file.Photographer
                        };
                        image.Images.push(imageObject);
                    });

                promises.push(response);
            }
            return $q.all(promises);
        }
    };

    uploadFactory.image = function () {
        return image;
    };

    return uploadFactory;
});

edited Feb 20, 2014 at 14:02

answered Feb 20, 2014 at 9:32

jlb

20.1k8 gold badges38 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Lars Over a year ago

This makes all the images to be uploaded, but look at my controller code above. The uploadImages function is executed, but the code inside the .then(function () { is not, it just stops there. Does the uploadImages return correctly?

jlb Over a year ago

is it possible that some of the uploads are failing? Maybe add a .error callback to the $upload.upload promise and see..

Lars Over a year ago

No, I already have an error callback, I've just not added it with the code in this question for easier reading. All my uploads are valid and successful

jlb Over a year ago

Can you put a breakpoint in the success handler and make sure the defer.resolve(result) line is executed? Unfortunately I can't really see what could be wrong here.

jlb Over a year ago

Great. Just an FYI, instead of making new promises via $q.deferred() you can append the return value of $upload.upload(..) to the array that gets passed into $q.all().

|

Collectives™ on Stack Overflow

Angular promise in async loop function

1 Answer 1

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related