php calling function in string concatenation

Question

I have problem to calling function in string concatenation

i have this function :

function  site_url() {
    include("../connect.php");
    $title= mysql_query("select * from shop_option where shop_key='site_url' ");
    $row_title= mysql_fetch_array($title);
    print ''.$row_title['shop_feild'].'';
}

This function will tell website url eg ( http://google.com )

and i want to call this function in string concatenation

echo '<script language="javascript">'.'window.location =
    "'.site_url().'";'.'</script>';

i also called function into variable ! to testing but it's not work

$page = site_url();
echo '<script language="javascript">'.'window.location = "'.$page.'";'.'</script>';

so how can i call function when i want to string concatenation ?

"but it's not work" the error_log or inline error should give you a pretty good idea on what's wrong with your code — Adam Azad
– Adam Azad, Commented Feb 13, 2014 at 12:29
is that $row_title['shop_feild'] or shouldn't that be $row_title['shop_field'] — Axel Amthor
– Axel Amthor, Commented Feb 13, 2014 at 12:29

Andrew Mackrodt · Accepted Answer · 2014-02-13 12:30:22Z

3

You need to return the result of site_url rather than printing the text immediately.

function  site_url() {
    include("../connect.php");
    $title= mysql_query("select * from shop_option where shop_key='site_url' ");
    $row_title= mysql_fetch_array($title);
    return $row_title['shop_feild'];
}

answered Feb 13, 2014 at 12:30

Andrew Mackrodt

1,82614 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Axel Amthor · Accepted Answer · 2014-02-13 12:31:21Z

1

your function should not print but return the value:

function  site_url() {
    include("../connect.php");
    $title= mysql_query("select * from shop_option where shop_key='site_url' ");
    $row_title= mysql_fetch_array($title);
    return''.$row_title['shop_field'].'';
}

in order to pass it to the caller which then prints the returned value.

answered Feb 13, 2014 at 12:31

Axel Amthor

11.1k1 gold badge28 silver badges45 bronze badges

1 Comment

mickmackusa Over a year ago

Those empty string concatenations are unnecessary.

Yulian · Accepted Answer · 2014-02-13 12:31:28Z

0

Instead of print, use return:

function  site_url() {
    include("../connect.php");
    $title= mysql_query("select * from shop_option where shop_key='site_url' ");
    $row_title= mysql_fetch_array($title);
    return $row_title['shop_field'];
}

answered Feb 13, 2014 at 12:31

Yulian

3182 silver badges8 bronze badges

Comments

cheeZer · Accepted Answer · 2014-02-13 12:32:20Z

0

Your function site_url() does not return the selected value.

function  site_url() {
  include("../connect.php");
  $title= mysql_query("select * from shop_option where shop_key='site_url'");
  $row_title = mysql_fetch_array($title);
  return $row_title['shop_feild'];
}

answered Feb 13, 2014 at 12:32

cheeZer

4681 gold badge8 silver badges15 bronze badges

Collectives™ on Stack Overflow

php calling function in string concatenation

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related