Get all data from mysql display in div php javascript

Question

Hello my problem is simple , i have a table news , i have a button bt1 , and a div to show the results , i want to display all rows from table when i click the button,i only get the first row , how can i display all results ?

    <script>
function shownews(id) { <? php
    include('db.php');
    $query = mysql_query("SELECT * FROM news");
    while ($row = mysql_fetch_array($query)) {
        $a = $row['news_title'];
    } ?>
    var ab = <? php echo json_encode($a); ?> ;
    id.innerHTML = ab;
}
</script>
<div id="results"></div>
<button id="btn1" onclick="shownews(results)">See news</button>

You should use mysqli, mysql is deprecated.

Doggo
– Doggo

2014-02-07 11:30:34 +00:00
Commented Feb 7, 2014 at 11:30 — Doggo
– Doggo, Commented Feb 7, 2014 at 11:30

Janak Prajapati · Accepted Answer · 2014-02-07 11:36:15Z

1

try

$a = array();
while ($row = mysql_fetch_array($query)) {
            $a[] = $row['news_title'];
        } ?>
// print array

print_r($a);

answered Feb 7, 2014 at 11:36

Janak Prajapati

8761 gold badge10 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

cbreezier Over a year ago

$a = array(); is not necessary actually - ...the $var[] behaviour where a new array is created. (us2.php.net/array_push)

Pierre Granger · Accepted Answer · 2014-02-07 11:37:24Z

Your echo json_encode($a); is not in your while loop, so you only render 1 line. Also if i understand what you're doing, you want your PHP to be executed only when you trigger your button click ? This is not the way to do it... php is a server language where javascript is executed only by your browser.

I didn't

Try this :

<script type="text/javascript">
    function shownews(id) {
        document.getElementById(id).innerHTML = document.getElementById('news').innerHTML ;
    }
</script>
<div id="news" style="display:none ;">
<?php
    include ('db.php');
    $query=mysql_query("SELECT * FROM news");
    while($row=mysql_fetch_array($query)){
     echo $row['news_title'] . '<br />' ;
    }
?>
</div>
<div id="results"></div>
<button id="btn1" onclick="shownews('results')">See news</button>

Community · Accepted Answer · 2023-11-20 22:45:59Z

0

You are overwriting $a, hence you will only get the last row.

Change

while($row=mysql_fetch_array($query)){
    $a=$row['news_title'];
}

to

$a = array();
while($row=mysql_fetch_array($query)){
    array_push($a, $row['news_title']);
}

Edit: Royal_bg is correct - extra info:

Note: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function. https://www.php.net/array_push

edited Nov 20, 2023 at 22:45

CommunityBot

11 silver badge

answered Feb 7, 2014 at 11:32

cbreezier

1,3391 gold badge11 silver badges19 bronze badges

Comments

Maiar Hawkin · Accepted Answer · 2014-02-07 11:45:08Z

0

You execute all the while before writing anything. Try to change the closing bracket after writing the answer...

<script>

  function shownews(id){

<?php

    include ('db.php');
    $query=mysql_query("SELECT * FROM news");

    while($row=mysql_fetch_array($query)){
      $a=$row['news_title'];

?>

      var ab = <?php echo $a; ?>;
      id.innerHTML += ab;

<?php

    }

?>

  }
</script>

<div id="results"></div>
<button id="btn1" onclick="shownews(results)">See news</button>

edited Feb 7, 2014 at 11:45

answered Feb 7, 2014 at 11:35

Maiar Hawkin

11 bronze badge

1 Comment

cbreezier Over a year ago

Two things: json_encode is not necessary since $a is just a string. And this doesn't solve the problem since id.innerHTML=ab will overwrite what's in the div anyway.

Katyoshah · Accepted Answer · 2014-02-07 11:48:11Z

0

  function shownews(id){



  <?php
  include ('db.php');
  $query=mysql_query("SELECT * FROM news");

  while($row=mysql_fetch_array($query)){
  $a[]=$row['news_title'];

  }



   ?>


  id.innerHTML=<?php echo json_encode($a); ?>;

  }

answered Feb 7, 2014 at 11:48

Katyoshah

12910 bronze badges

Collectives™ on Stack Overflow

Get all data from mysql display in div php javascript

5 Answers 5

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related