SELECT string[] array of columns FROM Table

Question

What I want to achieve is, from this:

string[] QueryString = new string[]{
        "Column1",
        "Column2"
    };

Create this:

SELECT  Column1,Column2
FROM    SomeTable

I know that I could do a concat but that's not a very clean way to doit.

D Stanley · Accepted Answer · 2014-02-04 18:10:53Z

2

I know that I could do a concat but that's not a very clean way to do it.

Seems pretty clean to me:

string sql = "SELECT " + string.Join(", ", QueryString) + " FROM SomeTable";

Although you're susceptible to SQL injection attacks:

string[] QueryString = new string[]{
        " * FROM SomeTable; DROP TABLE SomeTable; --"
    };

So ONLY do this if you have complete control of the column names that can be used (e.g. populated from the table metadata).

edited Feb 4, 2014 at 18:10

answered Feb 4, 2014 at 18:02

D Stanley

153k12 gold badges189 silver badges257 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

skmasq Over a year ago

I have full control of column names.

p.s.w.g Over a year ago

@skmasq Also, you probably want to safely quote the identifiers, e.g. SELECT [Column1], [Column2] FROM [SomeTable], otherwise a column name like my column would cause errors.

Amir Keshavarz · Accepted Answer · 2014-02-04 18:03:34Z

0

Declare @qtext varchar(max) = 'select '+column1+ ' , '+column2+ ' from sometable ' 
Exec(@qtext)

answered Feb 4, 2014 at 18:03

Amir Keshavarz

3,1181 gold badge22 silver badges26 bronze badges

Comments

David S. · Accepted Answer · 2014-02-04 18:03:54Z

0

You could use String.Format

http://msdn.microsoft.com/en-us/library/system.string.format(v=vs.110).aspx

String query =
String.Format("SELECT {0}, {1} FROM SomeTable", QueryString[0], QueryString[1]);

Although, as always when constructing sql queries, be aware of sql injection attacks.

answered Feb 4, 2014 at 18:03

David S.

6,1332 gold badges45 silver badges82 bronze badges

2 Comments

Pranay Rana Over a year ago

this will not work when there is more than two columns

skmasq Over a year ago

@PranayRana is right, it's dynamic array, thus tag dynamic :D

Collectives™ on Stack Overflow

SELECT string[] array of columns FROM Table

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related